[wasm] Fix imports with numbers as name

[wasm] Fix imports with numbers as name

Object::GetProperty fails if the given name is a valid array index.
This CL switches to Object::GetPropertyOrElement for lookups of imports.
The new tests check that we now accept numbers as module name or
function name in FFI.

R=ahaas@chromium.org, titzer@chromium.org

Committed: https://crrev.com/c2db3b38989feb2825c7ce15fd944f446c6a2152
Cr-Commit-Position: refs/heads/master@{#41022}

[Clemens Hammacher, 2016-11-16 10:06:47]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 10:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-16 10:26:51]

On 2016/11/16 10:24:09, Clemens Hammacher wrote:

lgtm

[commit-bot: I haz the power, 2016-11-16 10:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 10:32:21]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-16 10:33:28]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-11-16 10:33:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 10:36:45]

Committed patchset #1 (id:1)

[ahaas, 2016-11-16 10:51:18]

lgtm with nits

https://codereview.chromium.org/2503313002/diff/1/test/mjsunit/wasm/ffi.js
File test/mjsunit/wasm/ffi.js (right):

https://codereview.chromium.org/2503313002/diff/1/test/mjsunit/wasm/ffi.js#ne...
test/mjsunit/wasm/ffi.js:298: (function testCallPrint() {
All other tests have the style

function name() {}
name();

I think you should keep all tests in this file consistent.

https://codereview.chromium.org/2503313002/diff/1/test/mjsunit/wasm/ffi.js#ne...
test/mjsunit/wasm/ffi.js:317: (function testImportNumbers() {
nits: It's a test, you can give it long descriptive names, like
"testImportWithNumberAsName"

[commit-bot: I haz the power, 2016-11-17 22:35:38]

Description was changed from

==========
[wasm] Fix imports with numbers as name

Object::GetProperty fails if the given name is a valid array index.
This CL switches to Object::GetPropertyOrElement for lookups of imports.
The new tests check that we now accept numbers as module name or
function name in FFI.

R=ahaas@chromium.org, titzer@chromium.org
==========

to

==========
[wasm] Fix imports with numbers as name

Object::GetProperty fails if the given name is a valid array index.
This CL switches to Object::GetPropertyOrElement for lookups of imports.
The new tests check that we now accept numbers as module name or
function name in FFI.

R=ahaas@chromium.org, titzer@chromium.org

Committed: https://crrev.com/c2db3b38989feb2825c7ce15fd944f446c6a2152
Cr-Commit-Position: refs/heads/master@{#41022}
==========

[commit-bot: I haz the power, 2016-11-17 22:35:39]

Patchset 1 (id:??) landed as
https://crrev.com/c2db3b38989feb2825c7ce15fd944f446c6a2152
Cr-Commit-Position: refs/heads/master@{#41022}