Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: src/wasm/wasm-module.cc

Issue 2503313002: [wasm] Fix imports with numbers as name (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/ffi.js » ('j') | test/mjsunit/wasm/ffi.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index 79b99fe04d90f0618cfdf557ff3dd10f14809d34..e8cb26b1ceed6b1fe03083c660884a338b62d09b 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -1289,7 +1289,8 @@ class WasmInstanceBuilder {
}
// Look up the module first.
- MaybeHandle<Object> result = Object::GetProperty(ffi_, module_name);
+ MaybeHandle<Object> result =
+ Object::GetPropertyOrElement(ffi_, module_name);
if (result.is_null()) {
return ReportFFIError("module not found", index, module_name,
import_name);
@@ -1304,7 +1305,8 @@ class WasmInstanceBuilder {
module_name, import_name);
}
- result = Object::GetProperty(module, import_name.ToHandleChecked());
+ result =
+ Object::GetPropertyOrElement(module, import_name.ToHandleChecked());
if (result.is_null()) {
return ReportFFIError("import not found", index, module_name,
import_name);
« no previous file with comments | « no previous file | test/mjsunit/wasm/ffi.js » ('j') | test/mjsunit/wasm/ffi.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698