Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2503023003: Add Mac and Windows RandomOrder bots (Closed)

Created:
4 years, 1 month ago by jeffcarp
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, qyearsley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Mac and Windows RandomOrder bots This is one of two CLs: - Chromium (this one): https://codereview.chromium.org/2503023003 - Build: https://chromium-review.googlesource.com/#/c/411940/ BUG=665605 Committed: https://crrev.com/314fb7382d5ce31ba0ef83946848308933eadf82 Cr-Commit-Position: refs/heads/master@{#433979}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove comment / question #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jeffcarp
4 years, 1 month ago (2016-11-18 20:16:36 UTC) #3
Dirk Pranke
https://codereview.chromium.org/2503023003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2503023003/diff/1/tools/mb/mb_config.pyl#newcode197 tools/mb/mb_config.pyl:197: 'WebKit Win - RandomOrder': 'release_bot_x86', # should this be ...
4 years, 1 month ago (2016-11-18 20:17:46 UTC) #4
Dirk Pranke
whoops, also, lgtm :).
4 years, 1 month ago (2016-11-18 20:17:56 UTC) #5
qyearsley
lgtm
4 years, 1 month ago (2016-11-22 19:18:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503023003/20001
4 years, 1 month ago (2016-11-22 19:46:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 21:10:30 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 21:13:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/314fb7382d5ce31ba0ef83946848308933eadf82
Cr-Commit-Position: refs/heads/master@{#433979}

Powered by Google App Engine
This is Rietveld 408576698