Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2502763002: [Offline pages, NTP] Unifying offline_pin_round(_black) icon (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages, NTP] Unifying offline_pin_round(_black) icon Removes offline_pin_black icon and replaces its usage with offline_pin_round. This patch is meant to be merged in M55 (without the _black icon removal, as it is not present there). BUG=664670, 663702 Committed: https://crrev.com/68cb4e748bb930a35ef2ae756dcb8d92db74263e Cr-Commit-Position: refs/heads/master@{#432228}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
fgorski
Ted, PTAL (This cleans up the old resource). The _round that is going to be ...
4 years, 1 month ago (2016-11-14 20:45:44 UTC) #2
Ted C
lgtm
4 years, 1 month ago (2016-11-15 16:54:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502763002/1
4 years, 1 month ago (2016-11-15 18:57:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 19:05:06 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 19:34:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68cb4e748bb930a35ef2ae756dcb8d92db74263e
Cr-Commit-Position: refs/heads/master@{#432228}

Powered by Google App Engine
This is Rietveld 408576698