Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2502763002: [Offline pages, NTP] Unifying offline_pin_round(_black) icon (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/most_visited_item.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <RelativeLayout 6 <RelativeLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto" 8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
9 xmlns:tools="http://schemas.android.com/tools" 9 xmlns:tools="http://schemas.android.com/tools"
10 android:id="@+id/snippets_card_view" 10 android:id="@+id/snippets_card_view"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 <!-- We can't add this ImageView as a CompoundDrawable to the TextView b ecause we want to 64 <!-- We can't add this ImageView as a CompoundDrawable to the TextView b ecause we want to
65 have different paddings between the favicon (which is a compound drawabl e on the TextView) 65 have different paddings between the favicon (which is a compound drawabl e on the TextView)
66 and the offline icon. --> 66 and the offline icon. -->
67 <ImageView 67 <ImageView
68 android:id="@+id/offline_icon" 68 android:id="@+id/offline_icon"
69 android:layout_width="@dimen/snippets_offline_icon_size" 69 android:layout_width="@dimen/snippets_offline_icon_size"
70 android:layout_height="@dimen/snippets_offline_icon_size" 70 android:layout_height="@dimen/snippets_offline_icon_size"
71 android:layout_marginStart="6dp" 71 android:layout_marginStart="6dp"
72 android:alpha="0.46" 72 android:alpha="0.46"
73 android:src="@drawable/offline_pin_black" 73 android:src="@drawable/offline_pin_round"
74 android:contentDescription="@string/accessibility_ntp_offline_badge" 74 android:contentDescription="@string/accessibility_ntp_offline_badge"
75 android:visibility="gone" /> 75 android:visibility="gone" />
76 76
77 </LinearLayout> 77 </LinearLayout>
78 78
79 <ImageView 79 <ImageView
80 android:id="@+id/article_thumbnail" 80 android:id="@+id/article_thumbnail"
81 android:background="@color/snippets_thumnail_placeholder_bg" 81 android:background="@color/snippets_thumnail_placeholder_bg"
82 android:layout_width="@dimen/snippets_thumbnail_size" 82 android:layout_width="@dimen/snippets_thumbnail_size"
83 android:layout_height="@dimen/snippets_thumbnail_size" 83 android:layout_height="@dimen/snippets_thumbnail_size"
84 android:layout_alignParentTop="true" 84 android:layout_alignParentTop="true"
85 android:layout_alignParentEnd="true" 85 android:layout_alignParentEnd="true"
86 android:layout_marginStart="16dp" 86 android:layout_marginStart="16dp"
87 android:scaleType="centerCrop" 87 android:scaleType="centerCrop"
88 android:contentDescription="@null" 88 android:contentDescription="@null"
89 android:src="@null" /> 89 android:src="@null" />
90 </RelativeLayout> 90 </RelativeLayout>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/most_visited_item.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698