Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Unified Diff: xfa/fwl/core/ifwl_checkbox.cpp

Issue 2502653002: Cleanup remaining IFWL files for visiblity and usage. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/core/ifwl_checkbox.cpp
diff --git a/xfa/fwl/core/ifwl_checkbox.cpp b/xfa/fwl/core/ifwl_checkbox.cpp
index 3aac3598c25d97b76806bff63b50bff60507f72e..04c1c95ea08ce9a260a2f78a3e5fbc68219bb9a1 100644
--- a/xfa/fwl/core/ifwl_checkbox.cpp
+++ b/xfa/fwl/core/ifwl_checkbox.cpp
@@ -143,20 +143,7 @@ void IFWL_CheckBox::DrawWidget(CFX_Graphics* pGraphics,
}
}
-int32_t IFWL_CheckBox::GetCheckState() {
- if ((m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CKB_3State) &&
- ((m_pProperties->m_dwStates & FWL_STATE_CKB_CheckMask) ==
- FWL_STATE_CKB_Neutral)) {
- return 2;
- }
- if ((m_pProperties->m_dwStates & FWL_STATE_CKB_CheckMask) ==
- FWL_STATE_CKB_Checked) {
- return 1;
- }
- return 0;
-}
-
-FWL_Error IFWL_CheckBox::SetCheckState(int32_t iCheck) {
+void IFWL_CheckBox::SetCheckState(int32_t iCheck) {
m_pProperties->m_dwStates &= ~FWL_STATE_CKB_CheckMask;
switch (iCheck) {
case 0: {
npm 2016/11/14 15:19:30 nit: I think we don't use braces in switch cases?
dsinclair 2016/11/14 16:40:37 Done.
@@ -172,10 +159,10 @@ FWL_Error IFWL_CheckBox::SetCheckState(int32_t iCheck) {
}
break;
}
- default: {}
+ default:
+ break;
}
Repaint(&m_rtClient);
- return FWL_Error::Succeeded;
}
void IFWL_CheckBox::Layout() {

Powered by Google App Engine
This is Rietveld 408576698