[parser] Only log messages using the pending error handling

[parser] Only log messages using the pending error handling

This shares the pending_error_handler from the parser to the preparser, allowing the preparser to directly log errors to it. This removes LogMessage from the loggers. ParserLogger::LogMessage was already unused, so this also removes error info from the preparse data altogether.

BUG=

Committed: https://crrev.com/8b649a41ec1332a20b5355a8647c36631304565e
Cr-Commit-Position: refs/heads/master@{#40984}

[Toon Verwaest, 2016-11-14 13:57:42]

verwaest@chromium.org changed reviewers:
+ vogelheim@chromium.org

[Toon Verwaest, 2016-11-14 13:57:42]

ptal

[Toon Verwaest, 2016-11-14 14:00:53]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 14:01:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 14:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 14:27:59]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-11-15 08:43:42]

lgtm

https://codereview.chromium.org/2502633002/diff/20001/src/pending-compilation...
File src/pending-compilation-error-handler.cc (right):

https://codereview.chromium.org/2502633002/diff/20001/src/pending-compilation...
src/pending-compilation-error-handler.cc:28: Handle<String>
PendingCompilationErrorHandler::FormatMessage(Isolate* isolate) {
Who calls this? Is it only for testing?

[Toon Verwaest, 2016-11-15 10:12:24]

https://codereview.chromium.org/2502633002/diff/20001/src/pending-compilation...
File src/pending-compilation-error-handler.cc (right):

https://codereview.chromium.org/2502633002/diff/20001/src/pending-compilation...
src/pending-compilation-error-handler.cc:28: Handle<String>
PendingCompilationErrorHandler::FormatMessage(Isolate* isolate) {
On 2016/11/15 08:43:42, vogelheim wrote:
> Who calls this? Is it only for testing?

Yeah just testing. It seems small enough that it doesn't matter it's here...

[Toon Verwaest, 2016-11-15 10:13:42]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-11-15 10:13:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 10:15:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:33:37]

Description was changed from

==========
[parser] Only log messages using the pending error handling

This shares the pending_error_handler from the parser to the preparser, allowing
the preparser to directly log errors to it. This removes LogMessage from the
loggers. ParserLogger::LogMessage was already unused, so this also removes error
info from the preparse data altogether.

BUG=
==========

to

==========
[parser] Only log messages using the pending error handling

This shares the pending_error_handler from the parser to the preparser, allowing
the preparser to directly log errors to it. This removes LogMessage from the
loggers. ParserLogger::LogMessage was already unused, so this also removes error
info from the preparse data altogether.

BUG=

Committed: https://crrev.com/8b649a41ec1332a20b5355a8647c36631304565e
Cr-Commit-Position: refs/heads/master@{#40984}
==========

[commit-bot: I haz the power, 2016-11-17 22:33:39]

Patchset 2 (id:??) landed as
https://crrev.com/8b649a41ec1332a20b5355a8647c36631304565e
Cr-Commit-Position: refs/heads/master@{#40984}