Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/parsing/preparser.cc

Issue 2502633002: [parser] Only log messages using the pending error handling (Closed)
Patch Set: Delete more unused code Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/preparser.h ('k') | src/pending-compilation-error-handler.h » ('j') | src/pending-compilation-error-handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/preparser.cc
diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc
index 1025b8b136987f0af54715d2c8e1d9fc4995a8b3..4cd00ee9ed84dec8dc229b06cae7cfdd01711fed 100644
--- a/src/parsing/preparser.cc
+++ b/src/parsing/preparser.cc
@@ -133,7 +133,7 @@ PreParser::PreParseResult PreParser::PreParseFunction(
} else if (stack_overflow()) {
return kPreParseStackOverflow;
} else if (!*ok) {
- DCHECK(log_.has_error());
+ DCHECK(pending_error_handler_->has_pending_error());
} else {
DCHECK_EQ(Token::RBRACE, scanner()->peek());
« no previous file with comments | « src/parsing/preparser.h ('k') | src/pending-compilation-error-handler.h » ('j') | src/pending-compilation-error-handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698