Issue 250263005: Remove --disable-threaded-html-parser flag from Chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250263005: Remove --disable-threaded-html-parser flag from Chromium (Closed)

Created:
6 years, 8 months ago by eseidel

Modified:
6 years, 8 months ago

Reviewers:
kinuko, Avi (use Gerrit), Peter Kasting

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove --disable-threaded-html-parser flag from Chromium This flag was useful 2 years ago when we brought up the threaded HTML parser, but its always on on all platforms now. https://codereview.chromium.org/254343002 makes this flag not do anything in Blink. Once this lands I'll remove the setting entirely from Blink. BUG=308321

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -11 lines)			Patch
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/common/common_param_traits_macros.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/web_preferences.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/shell/common/webkit_test_helpers.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/common/webpreferences.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

I'm not really sure who to grab as owners in chromium land. content/ and webkit/ ...

6 years, 8 months ago (2014-04-23 22:29:18 UTC) #2

eseidel

6 years, 8 months ago (2014-04-23 22:49:00 UTC) #5

Sigh.  Turns out webkit_unit_tests have a ton of dependencies on the threaded
parser being off by default in Blink.  Will need to sort through those before
this can land.

Expand Messages | Collapse Messages