Send <iframe srcdoc> to the threaded parser

Send <iframe srcdoc> to the threaded parser

There are no test changes as this should be
imperceptible to pages.  We already issued
srcdoc loads asynchronously, we just happened
to parse their contents synchronously as soon
as we got back to the runloop to issue the load.

Now that we use the threaded parser, parsing
and display of srcdoc iframes will be incremental
as well as should not interfere with other
mainthread tasks like js execution or RAF.

Unfortunately there are some other knobs I need
to turn in the HTML parser to make it less
aggressive about processing data to make the
don't-interfere-with-animations part of this
change a reality.

BUG=308321
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172798

[abarth-chromium, 2014-04-23 21:49:20]

lgtm

https://codereview.chromium.org/254343002/diff/1/Source/core/html/parser/HTML...
File Source/core/html/parser/HTMLParserOptions.cpp (right):

https://codereview.chromium.org/254343002/diff/1/Source/core/html/parser/HTML...
Source/core/html/parser/HTMLParserOptions.cpp:48: useThreading = settings &&
settings->threadedHTMLParser() && !document->url().isAboutBlankURL();
We should drop this setting too.

[eseidel, 2014-04-23 21:52:00]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-23 21:52:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/1

[eseidel, 2014-04-23 22:10:14]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-23 22:10:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/40001

[eseidel, 2014-04-23 22:10:55]

The CQ bit was unchecked by eseidel@chromium.org

[eseidel, 2014-04-23 22:10:56]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-23 22:11:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/40001

[commit-bot: I haz the power, 2014-04-23 22:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 22:25:36]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[eseidel, 2014-04-23 22:49:57]

webkit_unit_tests have a ton of depedencies on the threaded parser.  Going back
to the original change for just srcdoc and can try this and
https://codereview.chromium.org/250263005/ again later.

[eseidel, 2014-04-23 22:58:48]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-23 22:59:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/60001

[commit-bot: I haz the power, 2014-04-23 23:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 23:50:33]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[eseidel, 2014-04-24 00:21:06]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:21:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/60001

[commit-bot: I haz the power, 2014-04-24 00:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:22:16]

Failed to apply patch for Source/core/html/parser/HTMLParserOptions.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/parser/HTMLParserOptions.cpp
  Hunk #1 FAILED at 40.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/html/parser/HTMLParserOptions.cpp.rej

Patch:       Source/core/html/parser/HTMLParserOptions.cpp
Index: Source/core/html/parser/HTMLParserOptions.cpp
diff --git a/Source/core/html/parser/HTMLParserOptions.cpp
b/Source/core/html/parser/HTMLParserOptions.cpp
index
717a1d89e1de8f62f7d6a348899a084d4a699910..9e767f91812d2c1fca26cd9988ee65a1cdcd2032
100644
--- a/Source/core/html/parser/HTMLParserOptions.cpp
+++ b/Source/core/html/parser/HTMLParserOptions.cpp
@@ -40,12 +40,14 @@ HTMLParserOptions::HTMLParserOptions(Document* document)
     scriptEnabled = frame &&
frame->script().canExecuteScripts(NotAboutToExecuteScript);
     pluginsEnabled = frame &&
frame->loader().allowPlugins(NotAboutToInstantiatePlugin);
 
-    Settings* settings = document ? document->settings() : 0;
-    // We force the main-thread parser for about:blank and javascript: for
compatibility
+    // We force the main-thread parser for about:blank and
+    // javascript: (which uses about:blank urls) for compatibility
     // with historical synchronous loading/parsing behavior.
     // FIXME: Gecko does not load javascript: urls synchronously, why do we?
     // See LayoutTests/loader/iframe-sync-loads.html
-    // FIXME: Use isAboutBlankURL() instead of protocolIsAbout() to not include
about:srcdoc.
+    // FIXME: This setting should be removed but currently many
+    // webkit_unit_tests depend on parsing being synchronous. crbug.com/366354
+    Settings* settings = document ? document->settings() : 0;
     useThreading = settings && settings->threadedHTMLParser() &&
!document->url().protocolIsAbout();
 }

[eseidel, 2014-04-28 18:31:52]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/80001

[eseidel, 2014-04-28 19:01:39]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-04-28 19:02:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/254343002/90001

[commit-bot: I haz the power, 2014-04-28 20:13:30]

Change committed as 172798