Add UMA metrics to see the proportions of dialogs spawned by foremost pages.

Add UMA metrics to see the proportions of dialogs spawned by foremost pages.

BUG=629964
Committed: https://crrev.com/2e37adb47f024c062c8249c8c7f1ce88d936b231
Cr-Commit-Position: refs/heads/master@{#432093}

[Avi (use Gerrit), 2016-11-13 22:46:30]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-13 22:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-11-13 23:23:12]

avi@chromium.org changed reviewers:
+ isherman@chromium.org, rbyers@chromium.org

[Avi (use Gerrit), 2016-11-13 23:23:12]

Ilya for histograms, Rick for the review

[Rick Byers, 2016-11-13 23:36:27]

LGTM

https://codereview.chromium.org/2502493002/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2502493002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:91:
UMA_HISTOGRAM_ENUMERATION("JSDialogs.ForemostStatus.Alert",
Note that you could use UMA_HISTOGRAM_BOOLEAN for this.  I don't know if there's
any advantage - your histograms.xml reviewer may have an opinion.

https://codereview.chromium.org/2502493002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:91:
UMA_HISTOGRAM_ENUMERATION("JSDialogs.ForemostStatus.Alert",
nit: I'd find this simpler to read if you had only one UMA_HISTOGRAM_ENUMERATION
call and just make the histogram name conditional.  But I'm OK either way.

[commit-bot: I haz the power, 2016-11-13 23:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-13 23:49:57]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-13 23:52:56]

https://codereview.chromium.org/2502493002/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2502493002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:91:
UMA_HISTOGRAM_ENUMERATION("JSDialogs.ForemostStatus.Alert",
On 2016/11/13 23:36:27, Rick Byers wrote:
> Note that you could use UMA_HISTOGRAM_BOOLEAN for this.  I don't know if
there's
> any advantage - your histograms.xml reviewer may have an opinion.

Right....

Every time I do histograms I learn something I then forget. This was swiped from
another two-value enumeration that was less clearly true/false, so the reviewer
then preferred a two-valued enum.

"is foremost" is very boolean, so I'll switch.

[Avi (use Gerrit), 2016-11-13 23:53:31]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-13 23:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 01:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 01:04:30]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-14 14:56:34]

PTAL.

[Rick Byers, 2016-11-14 19:13:41]

On 2016/11/14 14:56:34, Avi wrote:
> PTAL.

LGTM

[Ilya Sherman, 2016-11-14 22:59:22]

LGTM

[Avi (use Gerrit), 2016-11-15 02:28:38]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 04:07:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 04:09:34]

Description was changed from

==========
Add UMA metrics to see the proportions of dialogs spawned by foremost pages.

BUG=629964
==========

to

==========
Add UMA metrics to see the proportions of dialogs spawned by foremost pages.

BUG=629964

Committed: https://crrev.com/2e37adb47f024c062c8249c8c7f1ce88d936b231
Cr-Commit-Position: refs/heads/master@{#432093}
==========

[commit-bot: I haz the power, 2016-11-15 04:09:36]

Patchset 2 (id:??) landed as
https://crrev.com/2e37adb47f024c062c8249c8c7f1ce88d936b231
Cr-Commit-Position: refs/heads/master@{#432093}