Add UMA metrics to see the proportions of dialogs spawned by foremost pages.

chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 58 matching lines @@
     UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementLessThanOne",
                          message_length);
   } else if (engagement_score < 5) {
     UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementOneToFive",
                          message_length);
   } else {
     UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementHigher",
                          message_length);
   }
 
+  content::WebContents* parent_web_contents =
+      WebContentsObserver::web_contents();
+  enum class Foremost {
+    FOREMOST = 0,
+    NOT_FOREMOST = 1,
+    MAX,
+  };
+  Foremost foremost = IsWebContentsForemost(parent_web_contents)
+                          ? Foremost::FOREMOST
+                          : Foremost::NOT_FOREMOST;
+  switch (message_type) {
+    case content::JAVASCRIPT_MESSAGE_TYPE_ALERT:
+      UMA_HISTOGRAM_ENUMERATION("JSDialogs.ForemostStatus.Alert",

[Rick Byers, 2016/11/13 23:36:27]

nit: I'd find this simpler to read if you had only one UMA_HISTOGRAM_ENUMERATION
call and just make the histogram name conditional.  But I'm OK either way.

[Rick Byers, 2016/11/13 23:36:27]

Note that you could use UMA_HISTOGRAM_BOOLEAN for this.  I don't know if there's
any advantage - your histograms.xml reviewer may have an opinion.

[Avi (use Gerrit), 2016/11/13 23:52:56]

Right....

Every time I do histograms I learn something I then forget. This was swiped from
another two-value enumeration that was less clearly true/false, so the reviewer
then preferred a two-valued enum.

"is foremost" is very boolean, so I'll switch.

+                                static_cast<int>(foremost),
+                                static_cast<int>(Foremost::MAX));
+      break;
+    case content::JAVASCRIPT_MESSAGE_TYPE_CONFIRM:
+      UMA_HISTOGRAM_ENUMERATION("JSDialogs.ForemostStatus.Confirm",
+                                static_cast<int>(foremost),
+                                static_cast<int>(Foremost::MAX));
+      break;
+    case content::JAVASCRIPT_MESSAGE_TYPE_PROMPT:
+      UMA_HISTOGRAM_ENUMERATION("JSDialogs.ForemostStatus.Prompt",
+                                static_cast<int>(foremost),
+                                static_cast<int>(Foremost::MAX));
+      break;
+  }
+
   if (IsEnabled()) {
-    content::WebContents* parent_web_contents =
-        WebContentsObserver::web_contents();
-
     if (!IsWebContentsForemost(parent_web_contents) &&
         message_type == content::JAVASCRIPT_MESSAGE_TYPE_PROMPT) {
       // Don't allow "prompt" dialogs to steal the user's focus. TODO(avi):
       // Eventually, for subsequent phases of http://bit.ly/project-oldspice,
       // turn off focus stealing for other dialog types.
       *did_suppress_message = true;
       return;
     }
 
     if (dialog_) {
@@ skipping 115 matching lines @@
   DCHECK(dialog_);
 
   dialog_->CloseDialogWithoutCallback();
   if (!suppress_callback)
     dialog_callback_.Run(success, user_input);
 
   dialog_.reset();
   dialog_callback_.Reset();
   BrowserList::RemoveObserver(this);
 }