Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Unified Diff: services/video_capture/service_impl.cc

Issue 2502483003: [Mojo Video Capture] Cleanup naming of classes/files in services/video_capture (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/video_capture/service_impl.h ('k') | services/video_capture/service_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/video_capture/service_impl.cc
diff --git a/services/video_capture/video_capture_service.cc b/services/video_capture/service_impl.cc
similarity index 72%
rename from services/video_capture/video_capture_service.cc
rename to services/video_capture/service_impl.cc
index d369416a1cd5c8305b6a75f7cb9e442f0003ca2e..877755b06f49589a6b584d6f9719ca15900f0551 100644
--- a/services/video_capture/video_capture_service.cc
+++ b/services/video_capture/service_impl.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "services/video_capture/video_capture_service.h"
+#include "services/video_capture/service_impl.h"
#include "base/message_loop/message_loop.h"
#include "media/capture/video/fake_video_capture_device_factory.h"
@@ -25,45 +25,42 @@ std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() {
namespace video_capture {
-VideoCaptureService::VideoCaptureService() : mock_device_factory_(nullptr) {}
+ServiceImpl::ServiceImpl() : mock_device_factory_(nullptr) {}
-VideoCaptureService::~VideoCaptureService() = default;
+ServiceImpl::~ServiceImpl() = default;
-bool VideoCaptureService::OnConnect(
- const service_manager::ServiceInfo& remote_info,
- service_manager::InterfaceRegistry* registry) {
- registry->AddInterface<mojom::VideoCaptureService>(this);
+bool ServiceImpl::OnConnect(const service_manager::ServiceInfo& remote_info,
+ service_manager::InterfaceRegistry* registry) {
+ registry->AddInterface<mojom::Service>(this);
return true;
}
-void VideoCaptureService::Create(
- const service_manager::Identity& remote_identity,
- mojom::VideoCaptureServiceRequest request) {
+void ServiceImpl::Create(const service_manager::Identity& remote_identity,
+ mojom::ServiceRequest request) {
service_bindings_.AddBinding(this, std::move(request));
}
-void VideoCaptureService::ConnectToDeviceFactory(
- mojom::VideoCaptureDeviceFactoryRequest request) {
+void ServiceImpl::ConnectToDeviceFactory(mojom::DeviceFactoryRequest request) {
LazyInitializeDeviceFactory();
factory_bindings_.AddBinding(device_factory_.get(), std::move(request));
}
-void VideoCaptureService::ConnectToFakeDeviceFactory(
- mojom::VideoCaptureDeviceFactoryRequest request) {
+void ServiceImpl::ConnectToFakeDeviceFactory(
+ mojom::DeviceFactoryRequest request) {
LazyInitializeFakeDeviceFactory();
fake_factory_bindings_.AddBinding(fake_device_factory_.get(),
std::move(request));
}
-void VideoCaptureService::ConnectToMockDeviceFactory(
- mojom::VideoCaptureDeviceFactoryRequest request) {
+void ServiceImpl::ConnectToMockDeviceFactory(
+ mojom::DeviceFactoryRequest request) {
LazyInitializeMockDeviceFactory();
mock_factory_bindings_.AddBinding(mock_device_factory_adapter_.get(),
std::move(request));
}
-void VideoCaptureService::AddDeviceToMockFactory(
- mojom::MockVideoCaptureDevicePtr device,
+void ServiceImpl::AddDeviceToMockFactory(
+ mojom::MockMediaDevicePtr device,
const media::VideoCaptureDeviceDescriptor& descriptor,
const AddDeviceToMockFactoryCallback& callback) {
LazyInitializeMockDeviceFactory();
@@ -71,7 +68,7 @@ void VideoCaptureService::AddDeviceToMockFactory(
callback.Run();
}
-void VideoCaptureService::LazyInitializeDeviceFactory() {
+void ServiceImpl::LazyInitializeDeviceFactory() {
if (device_factory_)
return;
@@ -85,7 +82,7 @@ void VideoCaptureService::LazyInitializeDeviceFactory() {
std::move(media_device_factory), base::Bind(CreateJpegDecoder));
}
-void VideoCaptureService::LazyInitializeFakeDeviceFactory() {
+void ServiceImpl::LazyInitializeFakeDeviceFactory() {
if (fake_device_factory_)
return;
@@ -94,7 +91,7 @@ void VideoCaptureService::LazyInitializeFakeDeviceFactory() {
base::Bind(&CreateJpegDecoder));
}
-void VideoCaptureService::LazyInitializeMockDeviceFactory() {
+void ServiceImpl::LazyInitializeMockDeviceFactory() {
if (mock_device_factory_)
return;
« no previous file with comments | « services/video_capture/service_impl.h ('k') | services/video_capture/service_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698