Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: services/video_capture/service_impl.cc

Issue 2502483003: [Mojo Video Capture] Cleanup naming of classes/files in services/video_capture (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/video_capture/service_impl.h ('k') | services/video_capture/service_main.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/video_capture/video_capture_service.h" 5 #include "services/video_capture/service_impl.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "media/capture/video/fake_video_capture_device_factory.h" 8 #include "media/capture/video/fake_video_capture_device_factory.h"
9 #include "media/capture/video/video_capture_buffer_pool.h" 9 #include "media/capture/video/video_capture_buffer_pool.h"
10 #include "media/capture/video/video_capture_buffer_tracker.h" 10 #include "media/capture/video/video_capture_buffer_tracker.h"
11 #include "media/capture/video/video_capture_jpeg_decoder.h" 11 #include "media/capture/video/video_capture_jpeg_decoder.h"
12 #include "services/service_manager/public/cpp/interface_registry.h" 12 #include "services/service_manager/public/cpp/interface_registry.h"
13 #include "services/video_capture/device_factory_media_to_mojo_adapter.h" 13 #include "services/video_capture/device_factory_media_to_mojo_adapter.h"
14 #include "services/video_capture/mock_device_factory.h" 14 #include "services/video_capture/mock_device_factory.h"
15 15
16 namespace { 16 namespace {
17 17
18 // TODO(chfremer): Replace with an actual decoder factory. 18 // TODO(chfremer): Replace with an actual decoder factory.
19 // https://crbug.com/584797 19 // https://crbug.com/584797
20 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() { 20 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() {
21 return nullptr; 21 return nullptr;
22 } 22 }
23 23
24 } // anonymous namespace 24 } // anonymous namespace
25 25
26 namespace video_capture { 26 namespace video_capture {
27 27
28 VideoCaptureService::VideoCaptureService() : mock_device_factory_(nullptr) {} 28 ServiceImpl::ServiceImpl() : mock_device_factory_(nullptr) {}
29 29
30 VideoCaptureService::~VideoCaptureService() = default; 30 ServiceImpl::~ServiceImpl() = default;
31 31
32 bool VideoCaptureService::OnConnect( 32 bool ServiceImpl::OnConnect(const service_manager::ServiceInfo& remote_info,
33 const service_manager::ServiceInfo& remote_info, 33 service_manager::InterfaceRegistry* registry) {
34 service_manager::InterfaceRegistry* registry) { 34 registry->AddInterface<mojom::Service>(this);
35 registry->AddInterface<mojom::VideoCaptureService>(this);
36 return true; 35 return true;
37 } 36 }
38 37
39 void VideoCaptureService::Create( 38 void ServiceImpl::Create(const service_manager::Identity& remote_identity,
40 const service_manager::Identity& remote_identity, 39 mojom::ServiceRequest request) {
41 mojom::VideoCaptureServiceRequest request) {
42 service_bindings_.AddBinding(this, std::move(request)); 40 service_bindings_.AddBinding(this, std::move(request));
43 } 41 }
44 42
45 void VideoCaptureService::ConnectToDeviceFactory( 43 void ServiceImpl::ConnectToDeviceFactory(mojom::DeviceFactoryRequest request) {
46 mojom::VideoCaptureDeviceFactoryRequest request) {
47 LazyInitializeDeviceFactory(); 44 LazyInitializeDeviceFactory();
48 factory_bindings_.AddBinding(device_factory_.get(), std::move(request)); 45 factory_bindings_.AddBinding(device_factory_.get(), std::move(request));
49 } 46 }
50 47
51 void VideoCaptureService::ConnectToFakeDeviceFactory( 48 void ServiceImpl::ConnectToFakeDeviceFactory(
52 mojom::VideoCaptureDeviceFactoryRequest request) { 49 mojom::DeviceFactoryRequest request) {
53 LazyInitializeFakeDeviceFactory(); 50 LazyInitializeFakeDeviceFactory();
54 fake_factory_bindings_.AddBinding(fake_device_factory_.get(), 51 fake_factory_bindings_.AddBinding(fake_device_factory_.get(),
55 std::move(request)); 52 std::move(request));
56 } 53 }
57 54
58 void VideoCaptureService::ConnectToMockDeviceFactory( 55 void ServiceImpl::ConnectToMockDeviceFactory(
59 mojom::VideoCaptureDeviceFactoryRequest request) { 56 mojom::DeviceFactoryRequest request) {
60 LazyInitializeMockDeviceFactory(); 57 LazyInitializeMockDeviceFactory();
61 mock_factory_bindings_.AddBinding(mock_device_factory_adapter_.get(), 58 mock_factory_bindings_.AddBinding(mock_device_factory_adapter_.get(),
62 std::move(request)); 59 std::move(request));
63 } 60 }
64 61
65 void VideoCaptureService::AddDeviceToMockFactory( 62 void ServiceImpl::AddDeviceToMockFactory(
66 mojom::MockVideoCaptureDevicePtr device, 63 mojom::MockMediaDevicePtr device,
67 const media::VideoCaptureDeviceDescriptor& descriptor, 64 const media::VideoCaptureDeviceDescriptor& descriptor,
68 const AddDeviceToMockFactoryCallback& callback) { 65 const AddDeviceToMockFactoryCallback& callback) {
69 LazyInitializeMockDeviceFactory(); 66 LazyInitializeMockDeviceFactory();
70 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor)); 67 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor));
71 callback.Run(); 68 callback.Run();
72 } 69 }
73 70
74 void VideoCaptureService::LazyInitializeDeviceFactory() { 71 void ServiceImpl::LazyInitializeDeviceFactory() {
75 if (device_factory_) 72 if (device_factory_)
76 return; 73 return;
77 74
78 // Create the platform-specific device factory. 75 // Create the platform-specific device factory.
79 // Task runner does not seem to actually be used. 76 // Task runner does not seem to actually be used.
80 std::unique_ptr<media::VideoCaptureDeviceFactory> media_device_factory = 77 std::unique_ptr<media::VideoCaptureDeviceFactory> media_device_factory =
81 media::VideoCaptureDeviceFactory::CreateFactory( 78 media::VideoCaptureDeviceFactory::CreateFactory(
82 base::MessageLoop::current()->task_runner()); 79 base::MessageLoop::current()->task_runner());
83 80
84 device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>( 81 device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
85 std::move(media_device_factory), base::Bind(CreateJpegDecoder)); 82 std::move(media_device_factory), base::Bind(CreateJpegDecoder));
86 } 83 }
87 84
88 void VideoCaptureService::LazyInitializeFakeDeviceFactory() { 85 void ServiceImpl::LazyInitializeFakeDeviceFactory() {
89 if (fake_device_factory_) 86 if (fake_device_factory_)
90 return; 87 return;
91 88
92 fake_device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>( 89 fake_device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
93 base::MakeUnique<media::FakeVideoCaptureDeviceFactory>(), 90 base::MakeUnique<media::FakeVideoCaptureDeviceFactory>(),
94 base::Bind(&CreateJpegDecoder)); 91 base::Bind(&CreateJpegDecoder));
95 } 92 }
96 93
97 void VideoCaptureService::LazyInitializeMockDeviceFactory() { 94 void ServiceImpl::LazyInitializeMockDeviceFactory() {
98 if (mock_device_factory_) 95 if (mock_device_factory_)
99 return; 96 return;
100 97
101 auto mock_device_factory = base::MakeUnique<MockDeviceFactory>(); 98 auto mock_device_factory = base::MakeUnique<MockDeviceFactory>();
102 // We keep a pointer to the MockDeviceFactory as a member so that we can 99 // We keep a pointer to the MockDeviceFactory as a member so that we can
103 // invoke its AddMockDevice(). Ownership of the MockDeviceFactory is moved 100 // invoke its AddMockDevice(). Ownership of the MockDeviceFactory is moved
104 // to the DeviceFactoryMediaToMojoAdapter. 101 // to the DeviceFactoryMediaToMojoAdapter.
105 mock_device_factory_ = mock_device_factory.get(); 102 mock_device_factory_ = mock_device_factory.get();
106 mock_device_factory_adapter_ = 103 mock_device_factory_adapter_ =
107 base::MakeUnique<DeviceFactoryMediaToMojoAdapter>( 104 base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
108 std::move(mock_device_factory), base::Bind(&CreateJpegDecoder)); 105 std::move(mock_device_factory), base::Bind(&CreateJpegDecoder));
109 } 106 }
110 107
111 } // namespace video_capture 108 } // namespace video_capture
OLDNEW
« no previous file with comments | « services/video_capture/service_impl.h ('k') | services/video_capture/service_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698