[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is
  an adapter to a mock exposing a Mojo interface. This makes it consistent with
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.
* Rename method CreateDeviceProxy() to CreateDevice().

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Committed: https://crrev.com/acdfa002bf1486501e0dcaf7615895bb6d0d0beb
Cr-Commit-Position: refs/heads/master@{#432647}

[chfremer, 2016-11-14 19:49:04]

Description was changed from

==========
presubmit


Merge branch 'DeviceId' into 1.9.5a


Merge branch 'DeviceId' into 1.9.5a


WIP

Merge branch 'DeviceId' into 1.9.5a


Merge branch 'DeviceId' into 1.9.5a


Merge branch 'DeviceId' into 1.9.5a


Rename classes and files in services/video_capture to remove redundant
"VideoCapture" part and to improve consistency in the naming scheme.

BUG=
==========

to

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in 
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is 
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that 
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is 
  an adapter to a mock exposing a Mojo interface. This makes it consistent with 
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better 
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2016-11-14 20:00:11]

Patchset #1 (id:1) has been deleted

[chfremer, 2016-11-14 20:00:22]

Description was changed from

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in 
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is 
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that 
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is 
  an adapter to a mock exposing a Mojo interface. This makes it consistent with 
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better 
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in 
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is 
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that 
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is 
  an adapter to a mock exposing a Mojo interface. This makes it consistent with 
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better 
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.
* Rename method CreateDeviceProxy() to CreateDevice().

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2016-11-14 20:00:49]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[chfremer, 2016-11-14 20:01:32]

chfremer@chromium.org changed reviewers:
+ mcasas@chromium.org

[chfremer, 2016-11-14 20:01:33]

mcasas@: PTAL

[commit-bot: I haz the power, 2016-11-14 20:02:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 20:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:16:40]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[chfremer, 2016-11-15 01:13:18]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:13:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:19:35]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-11-16 04:25:49]

lgtm with the style addressed.

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
File services/video_capture/public/interfaces/device.mojom (right):

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
services/video_capture/public/interfaces/device.mojom:18: Start(CaptureSettings
requested_settings,
reflow params to fit in one line.

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
File services/video_capture/public/interfaces/device_factory.mojom (right):

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
services/video_capture/public/interfaces/device_factory.mojom:38: // "revokes"
that previous |device_request| (by closing the connection) and the
reflow text.

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
File services/video_capture/service_impl.h (right):

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
services/video_capture/service_impl.h:43: mojom::DeviceFactoryRequest request)
override;
These three methods and the class declaration in l.21
and vicinity needs styling.

I suggest you run `git cl format` before uploading the
next patch, and inspect the changes. I think it should
do a good job in this case.

[chfremer, 2016-11-16 17:14:11]

chfremer@chromium.org changed reviewers:
+ tsepez@chromium.org

[chfremer, 2016-11-16 17:14:12]

tsepez@: Please RS *.mojom, *struct_traits*

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
File services/video_capture/public/interfaces/device.mojom (right):

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
services/video_capture/public/interfaces/device.mojom:18: Start(CaptureSettings
requested_settings,
On 2016/11/16 04:25:49, mcasas wrote:
> reflow params to fit in one line.

Done.

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
File services/video_capture/public/interfaces/device_factory.mojom (right):

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
services/video_capture/public/interfaces/device_factory.mojom:38: // "revokes"
that previous |device_request| (by closing the connection) and the
On 2016/11/16 04:25:49, mcasas wrote:
> reflow text.

Done.

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
File services/video_capture/service_impl.h (right):

https://codereview.chromium.org/2502483003/diff/40001/services/video_capture/...
services/video_capture/service_impl.h:43: mojom::DeviceFactoryRequest request)
override;
On 2016/11/16 04:25:49, mcasas wrote:
> These three methods and the class declaration in l.21
> and vicinity needs styling.
> 
> I suggest you run `git cl format` before uploading the
> next patch, and inspect the changes. I think it should
> do a good job in this case.

Done.

[Tom Sepez, 2016-11-16 18:35:42]

RS LGTM

[chfremer, 2016-11-16 18:56:18]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-11-16 18:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2502483003/#ps60001
(title: "mcasas comments and git cl format")

[commit-bot: I haz the power, 2016-11-16 18:57:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:04:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:04:36]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[chfremer, 2016-11-16 19:15:18]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-11-16 19:15:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2502483003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-16 19:16:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 22:36:15]

Description was changed from

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in 
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is 
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that 
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is 
  an adapter to a mock exposing a Mojo interface. This makes it consistent with 
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better 
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.
* Rename method CreateDeviceProxy() to CreateDevice().

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in 
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is 
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that 
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is 
  an adapter to a mock exposing a Mojo interface. This makes it consistent with 
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better 
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.
* Rename method CreateDeviceProxy() to CreateDevice().

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[commit-bot: I haz the power, 2016-11-16 22:36:16]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-16 22:43:06]

Description was changed from

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in 
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is 
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that 
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is 
  an adapter to a mock exposing a Mojo interface. This makes it consistent with 
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better 
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.
* Rename method CreateDeviceProxy() to CreateDevice().

This CL is part of the Mojo Video Capture work. For the bigger picture, 
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Cleanup naming of classes/files in services/video_capture

Goal of this CL is to use simple and consistent naming rules in
services/video_capture.
* Drop the "video_capture_" prefix from lots of files and classes, since it is
  redundant with the namespace.
* Rename VideoCaptureDeviceProxyImpl to DeviceMediaToMojoAdapter, since that
  describes what it is and is consistent with the other adapter classes.
* Replace *_mock_* with *_mojo_mock_* where appropriate to indicate that it is
  an adapter to a mock exposing a Mojo interface. This makes it consistent with
  other adapters exposing Mojo interfaces.
* Rename Mojo interface MockVideoCaptureDevice to MockMediaDevice to better
  convey that the purpose of this is to mock out a media::VideoCaptureDevice.
* Rename method CreateDeviceProxy() to CreateDevice().

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.5a

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...

Committed: https://crrev.com/acdfa002bf1486501e0dcaf7615895bb6d0d0beb
Cr-Commit-Position: refs/heads/master@{#432647}
==========

[commit-bot: I haz the power, 2016-11-16 22:43:07]

Patchset 4 (id:??) landed as
https://crrev.com/acdfa002bf1486501e0dcaf7615895bb6d0d0beb
Cr-Commit-Position: refs/heads/master@{#432647}