Fixed dragging a folder from bookmark manager to open all elements in new tabs

chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index f378828cfdf1d40db7a1f5e4733f2a893c25afbf..c75681ed0600373d2beedfbb64d8fd4e31455989 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -1028,24 +1028,23 @@ class NotificationBridge : public AppMenuIconController::Delegate {
     return;
   }
 
-  // TODO(viettrungluu): dropping multiple URLs?
-  if ([urls count] > 1)
-    NOTIMPLEMENTED();
-
-  // Get the first URL and fix it up.
-  GURL url(url_formatter::FixupURL(
-      base::SysNSStringToUTF8([urls objectAtIndex:0]), std::string()));
-
-  // Security: Sanitize text to prevent self-XSS.
-  if (url.SchemeIs(url::kJavaScriptScheme)) {
-    browser_->window()->GetLocationBar()->GetOmniboxView()->SetUserText(
-          OmniboxView::StripJavascriptSchemas(base::UTF8ToUTF16(url.spec())));
-    return;
+  for (id urlString in urls) {

[erikchen, 2016/11/14 18:22:53]

This code looks awfully similar to the previous changed code. I won't make you
refactor it, since the existing code was also copy-pasted. However, I would
appreciate it if you could:

1) File a bug indicating that this code needs to be refactored.
2) Add a comment here and in the previous file that indicates that the code
should be refactored:

Something like: // Refactor this code.
https://crbug.com/<insert_new_bug_id_here>.

[shahriar, 2016/11/15 02:51:12]

I looked for a common super/parent class, but they don't have it, otherwise I
would pull up the common code. 
If you have a suggestion, I would take your advice and refactor them in that
change request. 

+    GURL url = url_formatter::FixupURL(base::SysNSStringToUTF8(urlString),
+                                       std::string());
+
+    // If the URL isn't valid, don't bother.
+    if (!url.is_valid())
+      continue;
+
+    // Security: Sanitize text to prevent self-XSS.
+    if (url.SchemeIs(url::kJavaScriptScheme))
+      continue;
+
+    OpenURLParams params(url, Referrer(),
+                         WindowOpenDisposition::NEW_FOREGROUND_TAB,
+                         ui::PAGE_TRANSITION_TYPED, false);
+    browser_->tab_strip_model()->GetActiveWebContents()->OpenURL(params);
   }
-
-  OpenURLParams params(url, Referrer(), WindowOpenDisposition::CURRENT_TAB,
-                       ui::PAGE_TRANSITION_TYPED, false);
-  browser_->tab_strip_model()->GetActiveWebContents()->OpenURL(params);
 }
 
 // (URLDropTargetController protocol)