Fixed dragging a folder from bookmark manager to open all elements in new tabs

chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 
 #include <algorithm>
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
@@ skipping 1010 matching lines @@
 // (URLDropTargetController protocol)
 - (void)dropURLs:(NSArray*)urls inView:(NSView*)view at:(NSPoint)point {
   // TODO(viettrungluu): This code is more or less copied from the code in
   // |TabStripController|. I'll refactor this soon to make it common and expand
   // its capabilities (e.g., allow text DnD).
   if ([urls count] < 1) {
     NOTREACHED();
     return;
   }
 
-  // TODO(viettrungluu): dropping multiple URLs?
-  if ([urls count] > 1)
-    NOTIMPLEMENTED();
+  for (id urlString in urls) {

[erikchen, 2016/11/14 18:22:53]

This code looks awfully similar to the previous changed code. I won't make you
refactor it, since the existing code was also copy-pasted. However, I would
appreciate it if you could:

1) File a bug indicating that this code needs to be refactored.
2) Add a comment here and in the previous file that indicates that the code
should be refactored:

Something like: // Refactor this code.
https://crbug.com/<insert_new_bug_id_here>.

[shahriar, 2016/11/15 02:51:12]

I looked for a common super/parent class, but they don't have it, otherwise I
would pull up the common code. 
If you have a suggestion, I would take your advice and refactor them in that
change request. 

+    GURL url = url_formatter::FixupURL(base::SysNSStringToUTF8(urlString),
+                                       std::string());
 
-  // Get the first URL and fix it up.
-  GURL url(url_formatter::FixupURL(
-      base::SysNSStringToUTF8([urls objectAtIndex:0]), std::string()));
+    // If the URL isn't valid, don't bother.
+    if (!url.is_valid())
+      continue;
 
-  // Security: Sanitize text to prevent self-XSS.
-  if (url.SchemeIs(url::kJavaScriptScheme)) {
-    browser_->window()->GetLocationBar()->GetOmniboxView()->SetUserText(
-          OmniboxView::StripJavascriptSchemas(base::UTF8ToUTF16(url.spec())));
-    return;
+    // Security: Sanitize text to prevent self-XSS.
+    if (url.SchemeIs(url::kJavaScriptScheme))
+      continue;
+
+    OpenURLParams params(url, Referrer(),
+                         WindowOpenDisposition::NEW_FOREGROUND_TAB,
+                         ui::PAGE_TRANSITION_TYPED, false);
+    browser_->tab_strip_model()->GetActiveWebContents()->OpenURL(params);
   }
-
-  OpenURLParams params(url, Referrer(), WindowOpenDisposition::CURRENT_TAB,
-                       ui::PAGE_TRANSITION_TYPED, false);
-  browser_->tab_strip_model()->GetActiveWebContents()->OpenURL(params);
 }
 
 // (URLDropTargetController protocol)
 - (void)dropText:(NSString*)text inView:(NSView*)view at:(NSPoint)point {
   // TODO(viettrungluu): This code is more or less copied from the code in
   // |TabStripController|. I'll refactor this soon to make it common and expand
   // its capabilities (e.g., allow text DnD).
 
   // If the input is plain text, classify the input and make the URL.
   AutocompleteMatch match;
@@ skipping 20 matching lines @@
 - (void)hideDropURLsIndicatorInView:(NSView*)view {
   // Do nothing.
 }
 
 // (URLDropTargetController protocol)
 - (BOOL)isUnsupportedDropData:(id<NSDraggingInfo>)info {
   return drag_util::IsUnsupportedDropData(profile_, info);
 }
 
 @end