Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2502413005: Use aura::WindowProperty for title and name strings. (Closed)

Created:
4 years, 1 month ago by msw
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, je_julie, dmazzoni+watch_chromium.org, mcasas+watch+vc_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use aura::WindowProperty for title and name strings. Makes it easier to convert/transport these for mus. BUG=665245 TEST=No window titling/naming regressions. R=sky@chromium.org Committed: https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745 Cr-Commit-Position: refs/heads/master@{#433130}

Patch Set 1 #

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -36 lines) Patch
M ash/ash_touch_exploration_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/wm_window_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell/window_watcher_shelf_item_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc/desktop_media_list_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/client/aura_constants.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/window.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/aura/window.cc View 4 chunks +22 lines, -9 lines 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/window_reorderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/public/tooltip_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 1 month ago (2016-11-17 21:08:03 UTC) #1
sky
LGTM
4 years, 1 month ago (2016-11-18 00:37:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502413005/20001
4 years, 1 month ago (2016-11-18 01:31:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/275158)
4 years, 1 month ago (2016-11-18 04:55:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502413005/20001
4 years, 1 month ago (2016-11-18 05:47:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 06:15:04 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 06:19:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745
Cr-Commit-Position: refs/heads/master@{#433130}

Powered by Google App Engine
This is Rietveld 408576698