Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: ui/views/accessibility/ax_window_obj_wrapper.cc

Issue 2502413005: Use aura::WindowProperty for title and name strings. (Closed)
Patch Set: Update comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/aura/window.cc ('k') | ui/views/mus/desktop_window_tree_host_mus.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/accessibility/ax_window_obj_wrapper.h" 5 #include "ui/views/accessibility/ax_window_obj_wrapper.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "ui/accessibility/ax_node_data.h" 10 #include "ui/accessibility/ax_node_data.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // Also consider any associated widgets as children. 44 // Also consider any associated widgets as children.
45 Widget* widget = Widget::GetWidgetForNativeView(window_); 45 Widget* widget = Widget::GetWidgetForNativeView(window_);
46 if (widget && widget->IsVisible()) 46 if (widget && widget->IsVisible())
47 out_children->push_back(AXAuraObjCache::GetInstance()->GetOrCreate(widget)); 47 out_children->push_back(AXAuraObjCache::GetInstance()->GetOrCreate(widget));
48 } 48 }
49 49
50 void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) { 50 void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) {
51 out_node_data->id = GetID(); 51 out_node_data->id = GetID();
52 out_node_data->role = is_alert_ ? ui::AX_ROLE_ALERT : ui::AX_ROLE_WINDOW; 52 out_node_data->role = is_alert_ ? ui::AX_ROLE_ALERT : ui::AX_ROLE_WINDOW;
53 out_node_data->AddStringAttribute(ui::AX_ATTR_NAME, 53 out_node_data->AddStringAttribute(ui::AX_ATTR_NAME,
54 base::UTF16ToUTF8(window_->title())); 54 base::UTF16ToUTF8(window_->GetTitle()));
55 out_node_data->state = 0; 55 out_node_data->state = 0;
56 out_node_data->location = gfx::RectF(window_->bounds()); 56 out_node_data->location = gfx::RectF(window_->bounds());
57 } 57 }
58 58
59 int32_t AXWindowObjWrapper::GetID() { 59 int32_t AXWindowObjWrapper::GetID() {
60 return AXAuraObjCache::GetInstance()->GetID(window_); 60 return AXAuraObjCache::GetInstance()->GetID(window_);
61 } 61 }
62 62
63 void AXWindowObjWrapper::OnWindowDestroyed(aura::Window* window) { 63 void AXWindowObjWrapper::OnWindowDestroyed(aura::Window* window) {
64 AXAuraObjCache::GetInstance()->Remove(window, nullptr); 64 AXAuraObjCache::GetInstance()->Remove(window, nullptr);
65 } 65 }
66 66
67 void AXWindowObjWrapper::OnWindowDestroying(aura::Window* window) { 67 void AXWindowObjWrapper::OnWindowDestroying(aura::Window* window) {
68 Widget* widget = Widget::GetWidgetForNativeView(window); 68 Widget* widget = Widget::GetWidgetForNativeView(window);
69 if (widget) 69 if (widget)
70 AXAuraObjCache::GetInstance()->Remove(widget); 70 AXAuraObjCache::GetInstance()->Remove(widget);
71 } 71 }
72 72
73 void AXWindowObjWrapper::OnWindowHierarchyChanged( 73 void AXWindowObjWrapper::OnWindowHierarchyChanged(
74 const HierarchyChangeParams& params) { 74 const HierarchyChangeParams& params) {
75 if (params.phase == WindowObserver::HierarchyChangeParams::HIERARCHY_CHANGED) 75 if (params.phase == WindowObserver::HierarchyChangeParams::HIERARCHY_CHANGED)
76 AXAuraObjCache::GetInstance()->Remove(params.target, params.old_parent); 76 AXAuraObjCache::GetInstance()->Remove(params.target, params.old_parent);
77 } 77 }
78 78
79 } // namespace views 79 } // namespace views
OLDNEW
« no previous file with comments | « ui/aura/window.cc ('k') | ui/views/mus/desktop_window_tree_host_mus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698