[Download Home] More cleaning

[Download Home] More cleaning

* More uniformly handle how each of the lists of downloaded items
  from the three backends are manipulated.

* Add a new BackendItems class to encapsulate more of the list
  manipulating behavior.

* Pull out the LoadingStateDelegate into its own file.

* Stop differentiating between DownloadItemWrappers and
  OfflineItemWrappers unless it's necessary.

BUG=654630
Committed: https://crrev.com/b5e76d744d772f1ae8d6fe9b929c0a2257c258ef
Cr-Commit-Position: refs/heads/master@{#432918}

[gone, 2016-11-15 22:56:32]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2016-11-15 22:56:32]

Mostly moving code, but there's some adjusted logic in here to try and
consolidate everything.  Hopefully this will be a bit easier to maintain, but
please LMK if it looks worse.

Thanks!

[Theresa, 2016-11-17 00:42:33]

lgtm

https://codereview.chromium.org/2502113002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2502113002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:282:
void readdItemsToAdapter(List<DownloadHistoryItemWrapper> items) {
nit: I initially read this as "read items to adapter" instead of "re-add items
to adapter".  I'm don't have a grammatically strong argument, but I did find
this blog post that suggests adding a hyphen when it helps with readability is
okay. What do you think about making this reAddItemsToAdapter so that it's
easier to read?

http://english.stackexchange.com/questions/7731/adding-a-prefix-re-to-a-word-...

[gone, 2016-11-17 01:03:54]

https://codereview.chromium.org/2502113002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2502113002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:282:
void readdItemsToAdapter(List<DownloadHistoryItemWrapper> items) {
On 2016/11/17 00:42:33, Theresa Wellington wrote:
> nit: I initially read this as "read items to adapter" instead of "re-add items
> to adapter".  I'm don't have a grammatically strong argument, but I did find
> this blog post that suggests adding a hyphen when it helps with readability is
> okay. What do you think about making this reAddItemsToAdapter so that it's
> easier to read?
> 
>
http://english.stackexchange.com/questions/7731/adding-a-prefix-re-to-a-word-...

Done.

[gone, 2016-11-17 01:03:57]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-11-17 01:03:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2502113002/#ps20001
(title: "Comment")

[commit-bot: I haz the power, 2016-11-17 01:06:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 03:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:09:48]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)

[gone, 2016-11-17 17:51:23]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:52:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:26:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 18:32:56]

Description was changed from

==========
[Download Home] More cleaning

* More uniformly handle how each of the lists of downloaded items
  from the three backends are manipulated.

* Add a new BackendItems class to encapsulate more of the list
  manipulating behavior.

* Pull out the LoadingStateDelegate into its own file.

* Stop differentiating between DownloadItemWrappers and
  OfflineItemWrappers unless it's necessary.

BUG=654630
==========

to

==========
[Download Home] More cleaning

* More uniformly handle how each of the lists of downloaded items
  from the three backends are manipulated.

* Add a new BackendItems class to encapsulate more of the list
  manipulating behavior.

* Pull out the LoadingStateDelegate into its own file.

* Stop differentiating between DownloadItemWrappers and
  OfflineItemWrappers unless it's necessary.

BUG=654630

Committed: https://crrev.com/b5e76d744d772f1ae8d6fe9b929c0a2257c258ef
Cr-Commit-Position: refs/heads/master@{#432918}
==========

[commit-bot: I haz the power, 2016-11-17 18:32:57]

Patchset 2 (id:??) landed as
https://crrev.com/b5e76d744d772f1ae8d6fe9b929c0a2257c258ef
Cr-Commit-Position: refs/heads/master@{#432918}