Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java

Issue 2502113002: [Download Home] More cleaning (Closed)
Patch Set: Comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
index d36d94ca6e6c77f1d44bd5e41417f64136d71a98..2b16659e86abb25c1e7bc9b405c7fae214a1e61e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
@@ -121,7 +121,7 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
List<DownloadHistoryItemWrapper> items = (List<DownloadHistoryItemWrapper>) actionData;
// Deletion was undone. Add items back to the adapter.
- mHistoryAdapter.addItemsToAdapter(items);
+ mHistoryAdapter.reAddItemsToAdapter(items);
RecordUserAction.record("Android.DownloadManager.UndoDelete");
}
@@ -161,16 +161,16 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
private static BackendProvider sProviderForTests;
- private DownloadHistoryAdapter mHistoryAdapter;
+ private final DownloadHistoryAdapter mHistoryAdapter;
private final FilterAdapter mFilterAdapter;
private final ObserverList<DownloadUiObserver> mObservers = new ObserverList<>();
private final BackendProvider mBackendProvider;
private final SpaceDisplay mSpaceDisplay;
private final ListView mFilterView;
- private BasicNativePage mNativePage;
- private UndoDeletionSnackbarController mUndoDeletionSnackbarController;
+ private final UndoDeletionSnackbarController mUndoDeletionSnackbarController;
+ private BasicNativePage mNativePage;
private Activity mActivity;
private ViewGroup mMainView;
private DownloadManagerToolbar mToolbar;

Powered by Google App Engine
This is Rietveld 408576698