Offset rects by origin when projecting from composited to graphics layer.

Offset rects by origin when projecting from composited to graphics layer.

The origin for the graphics layer does not have to be the same as the
composited layer (e.g. when a child layer has negative offset and paints into
this layer), so when projecting rects to graphics layer space they have to be
offset by the origin for the composited layer.

Update internals to also return the rects with the offset set.

BUG=364346
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172462

[Ian Vollick, 2014-04-23 20:18:37]

Cool. Def needs a test, and I think you can reuse a bit of existing code in CLM.

https://codereview.chromium.org/250193002/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/250193002/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:455: LayoutPoint
graphicsLayerOffset  = compositedLayerMapping->compositedBounds().location();
It sounds like you want exactly
CompositedLayerMapping::contentOffsetInCompositingLayer. Perhaps this can be
made public.

[Zeeshan Qureshi, 2014-04-24 02:32:38]

Screenshot:
http://chromium.zqureshi.in/screenshots/rev-250193002-content-shell-offset-re...

The blue rect is the one with the transform and
the one to the left is absolutely positioned and has handler.

https://codereview.chromium.org/250193002/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/250193002/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:455: LayoutPoint
graphicsLayerOffset  = compositedLayerMapping->compositedBounds().location();
On 2014/04/23 20:18:38, Ian Vollick wrote:
> It sounds like you want exactly
> CompositedLayerMapping::contentOffsetInCompositingLayer. Perhaps this can be
> made public.

Excellent idea, done.

[Ian Vollick, 2014-04-24 03:15:28]

lgtm

https://codereview.chromium.org/250193002/diff/40001/Source/core/rendering/co...
File Source/core/rendering/compositing/CompositedLayerMapping.h (right):

https://codereview.chromium.org/250193002/diff/40001/Source/core/rendering/co...
Source/core/rendering/compositing/CompositedLayerMapping.h:202: LayoutSize
contentOffsetInCompositingLayer() const;
Thanks for fixing the typo :)

[Ian Vollick, 2014-04-24 03:16:12]

On 2014/04/24 03:15:28, Ian Vollick wrote:
> lgtm
> 
>
https://codereview.chromium.org/250193002/diff/40001/Source/core/rendering/co...
> File Source/core/rendering/compositing/CompositedLayerMapping.h (right):
> 
>
https://codereview.chromium.org/250193002/diff/40001/Source/core/rendering/co...
> Source/core/rendering/compositing/CompositedLayerMapping.h:202: LayoutSize
> contentOffsetInCompositingLayer() const;
> Thanks for fixing the typo :)

(Please don't submit until Rick signs off on the test, though.)

[Rick Byers, 2014-04-24 03:29:41]

Thanks, LGTM!

Please remove [WIP] from the issue description.

I assume you've verified that the original issue the user reported is fixed (and
the touch handler rects in devtools all appear in reasonable places for their
scenario), right?  I'm a little nervous there's some more edge cases here, but
this case seems straight forward enough now.

[Zeeshan Qureshi, 2014-04-24 03:47:22]

I verified the original bug and a couple of hand made cases, I was expecting at
least something
to break with this but haven't hit anything yet, I guess we'll know if stuff
happens in ClusterFuzz.

[Zeeshan Qureshi, 2014-04-24 03:48:40]

The CQ bit was checked by zeeshanq@chromium.org

[commit-bot: I haz the power, 2014-04-24 03:48:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/250193002/40001

[commit-bot: I haz the power, 2014-04-24 04:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 04:25:00]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Zeeshan Qureshi, 2014-04-24 04:47:47]

The CQ bit was checked by zeeshanq@chromium.org

[commit-bot: I haz the power, 2014-04-24 04:47:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/250193002/50001

[commit-bot: I haz the power, 2014-04-24 05:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 05:20:38]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[Zeeshan Qureshi, 2014-04-24 06:29:36]

The CQ bit was checked by zeeshanq@chromium.org

[commit-bot: I haz the power, 2014-04-24 06:29:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/250193002/50001

[commit-bot: I haz the power, 2014-04-24 07:00:52]

Change committed as 172462