Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2879)

Unified Diff: chromecast/browser/cast_content_browser_client.h

Issue 2501913002: Change the NaCl loader and broker processes to use the ServiceManager. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.h
diff --git a/chromecast/browser/cast_content_browser_client.h b/chromecast/browser/cast_content_browser_client.h
index cc07dcb77a6ec003ba135fd856db63cb2b03d670..058d75591a20a669826976cd426646e42348d601 100644
--- a/chromecast/browser/cast_content_browser_client.h
+++ b/chromecast/browser/cast_content_browser_client.h
@@ -158,7 +158,7 @@ class CastContentBrowserClient : public content::ContentBrowserClient {
content::RenderProcessHost* render_process_host) override;
void RegisterInProcessServices(StaticServiceMap* services) override;
std::unique_ptr<base::Value> GetServiceManifestOverlay(
- const std::string& service_name) override;
+ base::StringPiece service_name) override;
Mark Seaborn 2016/12/19 19:17:05 Could you explain in the commit message why this c
Sam McNally 2016/12/19 23:05:22 Done.
#if defined(OS_ANDROID)
void GetAdditionalMappedFilesForChildProcess(
const base::CommandLine& command_line,
« no previous file with comments | « chrome/browser/chrome_content_browser_manifest_overlay.json ('k') | chromecast/browser/cast_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698