Change the NaCl loader and broker processes to use the ServiceManager.

chromecast/browser/cast_content_browser_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
 #define CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 140 matching lines @@
       content::ResourceContext* context,
       int render_process_id,
       int opener_render_view_id,
       int opener_render_frame_id,
       bool* no_javascript_access) override;
   void ExposeInterfacesToRenderer(
       service_manager::InterfaceRegistry* registry,
       content::RenderProcessHost* render_process_host) override;
   void RegisterInProcessServices(StaticServiceMap* services) override;
   std::unique_ptr<base::Value> GetServiceManifestOverlay(
-      const std::string& service_name) override;
+      base::StringPiece service_name) override;

[Mark Seaborn, 2016/12/19 19:17:05]

Could you explain in the commit message why this change involves converting
these other parts of the codebase to use StringPiece?  (Would it be better to do
this conversion as a separate change?)

[Sam McNally, 2016/12/19 23:05:22]

Done.

 #if defined(OS_ANDROID)
   void GetAdditionalMappedFilesForChildProcess(
       const base::CommandLine& command_line,
       int child_process_id,
       content::FileDescriptorInfo* mappings,
       std::map<int, base::MemoryMappedFile::Region>* regions) override;
 #else
   ::media::ScopedAudioManagerPtr CreateAudioManager(
       ::media::AudioLogFactory* audio_log_factory) override;
   std::unique_ptr<::media::CdmFactory> CreateCdmFactory() override;
@@ skipping 37 matching lines @@
   CastBrowserMainParts* cast_browser_main_parts_;
   std::unique_ptr<URLRequestContextFactory> url_request_context_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient);
 };
 
 }  // namespace shell
 }  // namespace chromecast
 
 #endif  // CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_