Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2501773002: Disable fullscren fb optimization with sw mirroring. (Closed)

Created:
4 years, 1 month ago by Daniele Castagna
Modified:
4 years, 1 month ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Disable fullscren fb optimization with sw mirroring. Merge to M55. Display software mirroring copies the current fb into a texture and draws with that. This CL disables fullscreen fb optimization and always falls back to GL compositing when SW mirroring is enabled. BUG=662621 TEST=ran on kevin with sw mirroring and fs app. NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2476103002 Cr-Commit-Position: refs/heads/master@{#431184} (cherry picked from commit ccca423509d132e9c704188c284e7f11cba4f856)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M cc/output/overlay_strategy_fullscreen.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/output/overlay_strategy_fullscreen.cc View 2 chunks +10 lines, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M components/display_compositor/compositor_overlay_candidate_validator_ozone.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Daniele Castagna
4 years, 1 month ago (2016-11-14 22:53:29 UTC) #2
reveman
lgtm
4 years, 1 month ago (2016-11-15 00:02:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501773002/1
4 years, 1 month ago (2016-11-15 00:04:22 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 1 month ago (2016-11-15 00:04:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501773002/1
4 years, 1 month ago (2016-11-15 01:14:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 01:42:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698