Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2476103002: Disable fullscren fb optimization with sw mirroring. (Closed)

Created:
4 years, 1 month ago by Daniele Castagna
Modified:
4 years, 1 month ago
Reviewers:
reveman, ccameron
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable fullscren fb optimization with sw mirroring. Display software mirroring copies the current fb into a texture and draws with that. This CL disables fullscreen fb optimization and always falls back to GL compositing when SW mirroring is enabled. BUG=662621 TEST=ran on kevin with sw mirroring and fs app. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/ccca423509d132e9c704188c284e7f11cba4f856 Cr-Commit-Position: refs/heads/master@{#431184}

Patch Set 1 #

Patch Set 2 : Make unittests compile. #

Patch Set 3 : We now call CheckOverlaySupport. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M cc/output/overlay_strategy_fullscreen.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/output/overlay_strategy_fullscreen.cc View 2 chunks +10 lines, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M components/display_compositor/compositor_overlay_candidate_validator_ozone.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
Daniele Castagna
4 years, 1 month ago (2016-11-05 02:25:05 UTC) #5
reveman
lgtm
4 years, 1 month ago (2016-11-05 02:34:24 UTC) #6
Daniele Castagna
+Chris for ownership.
4 years, 1 month ago (2016-11-05 03:13:16 UTC) #12
ccameron
lgtm
4 years, 1 month ago (2016-11-10 03:57:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476103002/40001
4 years, 1 month ago (2016-11-10 03:58:20 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-10 04:47:59 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 04:51:23 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ccca423509d132e9c704188c284e7f11cba4f856
Cr-Commit-Position: refs/heads/master@{#431184}

Powered by Google App Engine
This is Rietveld 408576698