Indexed DB: Remove 'webkit'-prefixed global aliases

Indexed DB: Remove 'webkit'-prefixed global aliases

Remove webkitIndexedDB entry point alias, as well as 'webkitIDBXyz'
aliases for the global constructors.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTvAgAJ
BUG=665243
R=foolip@chromium.org

Committed: https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92
Cr-Commit-Position: refs/heads/master@{#433663}

[jsbell, 2016-11-15 01:04:12]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:05:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:36:16]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-11-17 19:18:28]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-11-17 19:18:57]

foolip@ - please take a look?

Won't land until after the M56 branch.

[commit-bot: I haz the power, 2016-11-17 19:19:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-11-17 19:42:13]

I like red diffs, LGTM.

Please internets, no regressions on this.

https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js
(left):

https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js:6:
description("Ensure that some obsolete IndexedDB features are gone.");
Some unrelated things in here, maybe upstream the good bits to
wpt/indexeddb/historical.html, if it's not already there?

https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/indexeddb/WindowIndexedDatabase.idl
(right):

https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/indexeddb/WindowIndexedDatabase.idl:30:
[MeasureAs=UnprefixedIndexedDB] readonly attribute IDBFactory indexedDB;
Totally unrelated, but I filed https://github.com/w3c/IndexedDB/issues/116

[commit-bot: I haz the power, 2016-11-17 21:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:31:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2016-11-18 00:16:14]

https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js
(left):

https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js:6:
description("Ensure that some obsolete IndexedDB features are gone.");
On 2016/11/17 19:42:13, foolip wrote:
> Some unrelated things in here, maybe upstream the good bits to
> wpt/indexeddb/historical.html, if it's not already there?

Sure - https://github.com/w3c/web-platform-tests/pull/4225

[jsbell, 2016-11-21 17:31:34]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:32:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:49:54]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2016-11-21 18:22:24]

Build failure due to:

../../third_party/WebKit/Source/core/frame/Deprecation.cpp:57:8: error: unused
function 'replacedWillBeRemoved' [-Werror,-Wunused-function]

After https://codereview.chromium.org/2497583002 this became the last use of the
method. I don't want to delete it since it's the preferred function now (i.e. we
should only deprecate when we have a target milestone)...

[jsbell, 2016-11-21 19:56:55]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-11-21 19:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2501743003/#ps40001
(title: "#if 0 as the least bad option?")

[commit-bot: I haz the power, 2016-11-21 19:57:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-11-21 20:35:38]

https://codereview.chromium.org/2501743003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2501743003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:57: #if 0
Yeah, I guess this works. I have deleted one of these when it became unused
before, and it made for compile problems when merging something to a branch
later. I guess that'll still happen, but fixing it will be slightly easier.

[commit-bot: I haz the power, 2016-11-21 21:58:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479758215293820,
"parent_rev": "402b1e0ca3d1a1482ecc1bb4001712bf80f5cde5", "commit_rev":
"bf8102aa52d76167698c5e607636c8df21d27205"}

[commit-bot: I haz the power, 2016-11-21 21:59:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-21 22:05:42]

Description was changed from

==========
Indexed DB: Remove 'webkit'-prefixed global aliases

Remove webkitIndexedDB entry point alias, as well as 'webkitIDBXyz'
aliases for the global constructors.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTv...
BUG=665243
R=foolip@chromium.org
==========

to

==========
Indexed DB: Remove 'webkit'-prefixed global aliases

Remove webkitIndexedDB entry point alias, as well as 'webkitIDBXyz'
aliases for the global constructors.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTv...
BUG=665243
R=foolip@chromium.org

Committed: https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92
Cr-Commit-Position: refs/heads/master@{#433663}
==========

[commit-bot: I haz the power, 2016-11-21 22:05:44]

Patchset 3 (id:??) landed as
https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92
Cr-Commit-Position: refs/heads/master@{#433663}