Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2501743003: Indexed DB: Remove 'webkit'-prefixed global aliases (Closed)

Created:
4 years, 1 month ago by jsbell
Modified:
4 years, 1 month ago
Reviewers:
foolip
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, jsbell+idb_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, haraken, kinuko+serviceworker, cmumford, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Remove 'webkit'-prefixed global aliases Remove webkitIndexedDB entry point alias, as well as 'webkitIDBXyz' aliases for the global constructors. Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTvAgAJ BUG=665243 R=foolip@chromium.org Committed: https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92 Cr-Commit-Position: refs/heads/master@{#433663}

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 3

Patch Set 3 : #if 0 as the least bad option? #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1643 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-properties-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 2 chunks +0 lines, -108 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +0 lines, -123 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +0 lines, -123 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/removed.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/removed-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/resources/unprefix.js View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/unprefix.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-workers.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-workers-expected.txt View 1 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 2 chunks +0 lines, -108 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 chunks +0 lines, -106 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 3 chunks +0 lines, -122 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +0 lines, -123 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 chunks +0 lines, -114 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 2 chunks +0 lines, -123 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 chunks +0 lines, -124 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +0 lines, -125 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 2 chunks +0 lines, -116 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 chunks +3 lines, -36 lines 1 comment Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WindowIndexedDatabase.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
jsbell
foolip@ - please take a look? Won't land until after the M56 branch.
4 years, 1 month ago (2016-11-17 19:18:57 UTC) #6
foolip
I like red diffs, LGTM. Please internets, no regressions on this. https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js File third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js (left): ...
4 years, 1 month ago (2016-11-17 19:42:13 UTC) #8
jsbell
https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js File third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js (left): https://codereview.chromium.org/2501743003/diff/20001/third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js#oldcode6 third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js:6: description("Ensure that some obsolete IndexedDB features are gone."); On ...
4 years, 1 month ago (2016-11-18 00:16:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501743003/20001
4 years, 1 month ago (2016-11-21 17:32:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/167736) blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-21 17:49:54 UTC) #15
jsbell
Build failure due to: ../../third_party/WebKit/Source/core/frame/Deprecation.cpp:57:8: error: unused function 'replacedWillBeRemoved' [-Werror,-Wunused-function] After https://codereview.chromium.org/2497583002 this became the ...
4 years, 1 month ago (2016-11-21 18:22:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501743003/40001
4 years, 1 month ago (2016-11-21 19:57:34 UTC) #19
foolip
https://codereview.chromium.org/2501743003/diff/40001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2501743003/diff/40001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode57 third_party/WebKit/Source/core/frame/Deprecation.cpp:57: #if 0 Yeah, I guess this works. I have ...
4 years, 1 month ago (2016-11-21 20:35:38 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 21:59:19 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 22:05:44 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92
Cr-Commit-Position: refs/heads/master@{#433663}

Powered by Google App Engine
This is Rietveld 408576698