Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2497583002: Remove webkitCancelRequestAnimationFrame (Closed)

Created:
4 years, 1 month ago by rwlbuis
Modified:
4 years, 1 month ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove webkitCancelRequestAnimationFrame Remove webkitCancelRequestAnimationFrame from Blink. Original Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3SZWAFN5uEY/s-RP_il6CAAJ BUG=146849 Committed: https://crrev.com/4312c9f8688669f7adb6a6102cf73e8e58777c8d Cr-Commit-Position: refs/heads/master@{#433410}

Patch Set 1 #

Patch Set 2 : Fix test failure #

Patch Set 3 : Patch for landing #

Patch Set 4 : Patch for landing try 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
D third_party/WebKit/LayoutTests/fast/animation/webkit-cancel-request-animation-frame.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/animation/webkit-cancel-request-animation-frame-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 33 (19 generated)
rwlbuis
PTAL. It seems M56 branch point is not announced yet, but in any case it ...
4 years, 1 month ago (2016-11-11 20:00:36 UTC) #4
Eric Willigers
lgtm
4 years, 1 month ago (2016-11-18 02:47:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497583002/40001
4 years, 1 month ago (2016-11-18 13:39:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/308127)
4 years, 1 month ago (2016-11-18 13:48:26 UTC) #14
rwlbuis
@rbyers PTAL looks like I need okay for the web exposed layout test changes. Will ...
4 years, 1 month ago (2016-11-18 14:06:26 UTC) #16
Rick Byers
On 2016/11/18 14:06:26, rwlbuis wrote: > @rbyers PTAL looks like I need okay for the ...
4 years, 1 month ago (2016-11-18 18:22:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497583002/60001
4 years, 1 month ago (2016-11-18 18:32:44 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/275871) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-18 20:35:17 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497583002/60001
4 years, 1 month ago (2016-11-18 20:51:07 UTC) #24
Eric Willigers
We are waiting for M56 branch point to be announced.
4 years, 1 month ago (2016-11-18 20:57:00 UTC) #26
rwlbuis
On 2016/11/18 20:57:00, Eric Willigers wrote: > We are waiting for M56 branch point to ...
4 years, 1 month ago (2016-11-18 21:09:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497583002/60001
4 years, 1 month ago (2016-11-19 04:54:28 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-19 07:12:22 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 07:14:38 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4312c9f8688669f7adb6a6102cf73e8e58777c8d
Cr-Commit-Position: refs/heads/master@{#433410}

Powered by Google App Engine
This is Rietveld 408576698