Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2501643002: Add reproduce steps (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, eyaich1, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add reproduce steps These were somehow missed in the new UI transition. BUG=665039 Committed: https://github.com/luci/luci-py/commit/c2580f39fbe0dafef5f8fdad86e0180caf91e7e8

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 6 chunks +30 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
kjlubick
See it live at https://2478-ef55a41-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task?id=327cc4e8a3e0a510&refresh=10&show_raw=1 https://screenshot.googleplex.com/crMds0hJCgJ
4 years, 1 month ago (2016-11-14 17:52:38 UTC) #2
stephana
On 2016/11/14 17:52:38, kjlubick wrote: > See it live at > https://2478-ef55a41-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task?id=327cc4e8a3e0a510&refresh=10&show_raw=1 > > https://screenshot.googleplex.com/crMds0hJCgJ ...
4 years, 1 month ago (2016-11-14 18:17:08 UTC) #4
KevinL
lgtm
4 years, 1 month ago (2016-11-15 13:23:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501643002/1
4 years, 1 month ago (2016-11-15 13:23:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3280f99381f23c10)
4 years, 1 month ago (2016-11-15 13:26:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501643002/20001
4 years, 1 month ago (2016-11-15 13:29:25 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 13:33:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/c2580f39fbe0dafef5f8fdad86e0180caf91e7e8

Powered by Google App Engine
This is Rietveld 408576698