Float selected columns to the top

Float selected columns to the top

BUG=664833
Committed: https://github.com/luci/luci-py/commit/d9de1b4d0668b329dc199bce7b34168312740c61

[kjlubick, 2016-11-14 17:27:03]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-11-14 17:27:04]

Live at
https://2478-ef55a41-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/botlist
(tasklist too)

https://screenshot.googleplex.com/gcRHOYQG0y1

[stephana, 2016-11-14 18:15:45]

https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
(right):

https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html:387:
return swarming.naturalCompare(a, b);
is (!selA && !selB) possible ?

[kjlubick, 2016-11-14 18:24:44]

https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
(right):

https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html:387:
return swarming.naturalCompare(a, b);
On 2016/11/14 at 18:15:45, stephana wrote:
> is (!selA && !selB) possible ?

Yes.  If both are selected or both are not selected, we sort alphabetically.

[mithro, 2016-11-15 01:12:31]

On 2016/11/14 18:24:44, kjlubick wrote:
>
https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
> File appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
> (right):
> 
>
https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
> appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html:387:
> return swarming.naturalCompare(a, b);
> On 2016/11/14 at 18:15:45, stephana wrote:
> > is (!selA && !selB) possible ?
> 
> Yes.  If both are selected or both are not selected, we sort alphabetically.

Random question, appengine/swarming/ui/build/elements.html seems to be generated
in some way -- it has a huge amount of minimized javascript in it? Generally you
don't want generated files in your repo...

Tim 'mithro' Ansell

[M-A Ruel, 2016-11-15 01:26:11]

On 2016/11/15 01:12:31, mithro wrote:
> Random question, appengine/swarming/ui/build/elements.html seems to be
generated
> in some way -- it has a huge amount of minimized javascript in it? Generally
you
> don't want generated files in your repo...

It's the vulcanized version. https://github.com/Polymer/vulcanize

We check it in so deploying to GAE doesn't require building anything.

[stephana, 2016-11-15 13:16:08]

lgtm

https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
(right):

https://codereview.chromium.org/2496303002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html:387:
return swarming.naturalCompare(a, b);
On 2016/11/14 18:24:43, kjlubick wrote:
> On 2016/11/14 at 18:15:45, stephana wrote:
> > is (!selA && !selB) possible ?
> 
> Yes.  If both are selected or both are not selected, we sort alphabetically.

Acknowledged.

[KevinL, 2016-11-15 13:18:04]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-11-15 13:18:04]

The CQ bit was checked by kjlubick@chromium.org

[KevinL, 2016-11-15 13:18:05]

lgtm

[commit-bot: I haz the power, 2016-11-15 13:18:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 13:21:54]

Description was changed from

==========
Float selected columns to the top

BUG=664833
==========

to

==========
Float selected columns to the top

BUG=664833

Committed:
https://github.com/luci/luci-py/commit/d9de1b4d0668b329dc199bce7b34168312740c61
==========

[commit-bot: I haz the power, 2016-11-15 13:21:55]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/d9de1b4d0668b329dc199bce7b34168312740c61