Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2501593002:
ChromeOS OOBE: Fix keyboard focusing of OOBE buttons. (Closed)
|
Created:
4 years, 1 month ago by Alexander Alekseev Modified:
4 years, 1 month ago Reviewers:
michaelpg CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChromeOS OOBE: Fix keyboard focusing of OOBE buttons.
BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/aef3f3bbbd791655a8bdca7d2905629087d9e647
Cr-Commit-Position: refs/heads/master@{#432450}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Updated formatting. #Patch Set 3 : Rebased. #Patch Set 4 : Rebased. #
Depends on Patchset: Messages
Total messages: 32 (23 generated)
Description was changed from ========== ChromeOS OOBE: Fix keyboard focusing of OOBE buttons. BUG=604119 ========== to ========== ChromeOS OOBE: Fix keyboard focusing of OOBE buttons. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alemate@chromium.org changed reviewers: + michaelpg@chromium.org
Please review.
This changelist basically moves all button decorations inside paper-button elements to allow the border of paper-buttoon itself to be user as keyboard focus flag.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
just nits https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_buttons.html (right): https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_buttons.html:89: <div id="subcontainer" class="flex layout horizontal center self-stretch"> keep lines to 80 characters https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_text_button.css (right): https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_text_button.css:7: border-color: rgba(66, 133, 244, 0.4); /* #4284f4 */ simplify all these into one border property and one border-radius property
https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_buttons.html (right): https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_buttons.html:89: <div id="subcontainer" class="flex layout horizontal center self-stretch"> On 2016/11/14 21:28:16, michaelpg wrote: > keep lines to 80 characters Done. https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_text_button.css (right): https://codereview.chromium.org/2501593002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_text_button.css:7: border-color: rgba(66, 133, 244, 0.4); /* #4284f4 */ On 2016/11/14 21:28:16, michaelpg wrote: > simplify all these into one border property and one border-radius property This doesn't work. It looks like shortcut properties are not supported in mixins. (Or may be in this mixin only, I don't know.)
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/2501593002/#ps60001 (title: "Rebased.")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2495153002 Patch 40001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== ChromeOS OOBE: Fix keyboard focusing of OOBE buttons. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== ChromeOS OOBE: Fix keyboard focusing of OOBE buttons. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aef3f3bbbd791655a8bdca7d2905629087d9e647 Cr-Commit-Position: refs/heads/master@{#432450} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/aef3f3bbbd791655a8bdca7d2905629087d9e647 Cr-Commit-Position: refs/heads/master@{#432450} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
