Chromium Code Reviews Chromium Code Reviews
Issue 2501593002:
ChromeOS OOBE: Fix keyboard focusing of OOBE buttons. (Closed)
| OLD | NEW |
|---|---|
| 1 <!-- Copyright 2016 The Chromium Authors. All rights reserved. | 1 <!-- Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 Use of this source code is governed by a BSD-style license that can be | 2 Use of this source code is governed by a BSD-style license that can be |
| 3 found in the LICENSE file. --> | 3 found in the LICENSE file. --> |
| 4 | 4 |
| 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> | 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html"> | 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html"> |
| 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> |
| 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-fab/paper-fab.htm l"> | 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-fab/paper-fab.htm l"> |
| 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> | 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> |
| 10 | 10 |
| (...skipping 21 matching lines...) Expand all Loading... | |
| 32 | 32 |
| 33 Attributes: | 33 Attributes: |
| 34 'disabled' - button is disabled when the attribute is set. | 34 'disabled' - button is disabled when the attribute is set. |
| 35 'inverse' - makes text white and background blue | 35 'inverse' - makes text white and background blue |
| 36 --> | 36 --> |
| 37 <dom-module id="oobe-text-button"> | 37 <dom-module id="oobe-text-button"> |
| 38 <link rel="stylesheet" href="oobe_text_button.css"> | 38 <link rel="stylesheet" href="oobe_text_button.css"> |
| 39 <template> | 39 <template> |
| 40 <paper-button id="textButton" on-tap="onClick_" disabled="[[disabled]]" | 40 <paper-button id="textButton" on-tap="onClick_" disabled="[[disabled]]" |
| 41 inverse$="[[inverse]]"> | 41 inverse$="[[inverse]]"> |
| 42 <content></content> | 42 <div id="container" class="flex layout horizontal center center-justified self-stretch"> |
| 43 <content></content> | |
| 44 </div> | |
| 43 </paper-button> | 45 </paper-button> |
| 44 </template> | 46 </template> |
| 45 </dom-module> | 47 </dom-module> |
| 46 | 48 |
| 47 <!-- | 49 <!-- |
| 48 Material design square "<- Back" button. | 50 Material design square "<- Back" button. |
| 49 Text is blue, background is white. | 51 Text is blue, background is white. |
| 50 | 52 |
| 51 Example: | 53 Example: |
| 52 <oobe-back-button on-tap="handleOnTap_"> | 54 <oobe-back-button on-tap="handleOnTap_"> |
| (...skipping 22 matching lines...) Expand all Loading... | |
| 75 <div i18n-content="oobeCloseButtonText"></div> | 77 <div i18n-content="oobeCloseButtonText"></div> |
| 76 </oobe-welcome-secondary-button> | 78 </oobe-welcome-secondary-button> |
| 77 | 79 |
| 78 Attributes: | 80 Attributes: |
| 79 'icon' - a name of icon from material design set to show on button. | 81 'icon' - a name of icon from material design set to show on button. |
| 80 'aria-label' - accessibility label. | 82 'aria-label' - accessibility label. |
| 81 --> | 83 --> |
| 82 <dom-module id="oobe-welcome-secondary-button"> | 84 <dom-module id="oobe-welcome-secondary-button"> |
| 83 <link rel="stylesheet" href="oobe_welcome_secondary_button.css"> | 85 <link rel="stylesheet" href="oobe_welcome_secondary_button.css"> |
| 84 <template> | 86 <template> |
| 85 <paper-button id="container" class="layout horizontal center" | 87 <paper-button id="button" aria-label="[[ariaLabel]]"> |
| 86 aria-label="[[ariaLabel]]"> | 88 <div id="container" class="flex layout vertical center self-stretch"> |
| 87 <iron-icon icon="[[icon]]" class="oobe-icon"></iron-icon> | 89 <div id="subcontainer" class="flex layout horizontal center self-stretch "> |
|
michaelpg
2016/11/14 21:28:16
keep lines to 80 characters
Alexander Alekseev
2016/11/14 22:19:04
Done.
| |
| 88 <content></content> | 90 <iron-icon icon="[[icon]]" class="oobe-icon"></iron-icon> |
| 91 <content></content> | |
| 92 </div> | |
| 93 </div> | |
| 89 </paper-button> | 94 </paper-button> |
| 90 </template> | 95 </template> |
| 91 </dom-module> | 96 </dom-module> |
| OLD | NEW |
