Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 250153002: Remove deprecated WebFrameClient methods, part 2/2. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Remove deprecated WebFrameClient methods, part 2/2. BUG=361761 TEST=everything stays green Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265774

Patch Set 1 #

Patch Set 2 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
Note sister change https://codereview.chromium.org/249973003.
6 years, 8 months ago (2014-04-23 20:08:43 UTC) #1
nasko
LGTM
6 years, 8 months ago (2014-04-23 20:32:19 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-23 21:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/250153002/20001
6 years, 8 months ago (2014-04-23 21:07:44 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 23:44:05 UTC) #5
Message was sent while issue was closed.
Change committed as 265774

Powered by Google App Engine
This is Rietveld 408576698