Media Galleries API: Audio/Video attached pictures support.

chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js

Index: chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js
diff --git a/chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js b/chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js
index 7da4a8a128acb030e13c2bea3401f211e1b720c8..c17381477fa0eb83698d8b69e46dabad1aa7d5c5 100644
--- a/chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js
+++ b/chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js
@@ -26,6 +26,9 @@ function RunMetadataTest(filename, callOptions, verifyMetadataFunction) {
 function ImageMIMETypeOnlyTest() {
   function verifyMetadata(metadata) {
     chrome.test.assertEq("image/jpeg", metadata.mimeType);
+
+    chrome.test.assertEq(0, metadata.attachedPictures.length);
+
     chrome.test.succeed();
   }
 
@@ -47,6 +50,9 @@ function ImageTagsTest() {
     chrome.test.assertEq(3.2, metadata.fNumber);
     chrome.test.assertEq(100, metadata.focalLengthMm);
     chrome.test.assertEq(1600, metadata.isoEquivalent);
+
+    chrome.test.assertEq(0, metadata.attachedPictures.length);
+
     chrome.test.succeed();
   }
 
@@ -57,6 +63,9 @@ function MP3MIMETypeOnlyTest() {
   function verifyMetadata(metadata) {
     chrome.test.assertEq("audio/mpeg", metadata.mimeType);
     chrome.test.assertEq(undefined, metadata.title);
+
+    chrome.test.assertEq(0, metadata.attachedPictures.length);
+
     chrome.test.succeed();
   }
 
@@ -88,6 +97,28 @@ function MP3TagsTest() {
 
     chrome.test.assertEq("png", metadata.rawTags[2].type);
 
+    chrome.test.assertEq(0, metadata.attachedPictures.length);
+
+    chrome.test.succeed();
+  }
+
+  return RunMetadataTest("id3_png_test.mp3", {metadataType: 'mimeTypeAndTags'},
+                         verifyMetadata);
+}
+
+function MP3AttachedImageTest() {
+  function verifyMetadata(metadata) {
+    chrome.test.assertEq("audio/mpeg", metadata.mimeType);
+    chrome.test.assertEq("Airbag", metadata.title);
+    chrome.test.assertEq("Radiohead", metadata.artist);
+    chrome.test.assertEq("OK Computer", metadata.album);
+    chrome.test.assertEq(1, metadata.track);
+    chrome.test.assertEq("Alternative", metadata.genre);
+
+    chrome.test.assertEq(1, metadata.attachedPictures.length);
+    chrome.test.assertEq('image/png', metadata.attachedPictures[0].type);
+    chrome.test.assertEq(155752, metadata.attachedPictures[0].size);

[vandebo (ex-Chrome), 2014/04/23 23:22:45]

Maybe check a few bytes at the start and end as well?

[tommycli, 2014/04/29 00:15:51]

Done.

+
     chrome.test.succeed();
   }
 
@@ -124,6 +155,8 @@ function RotatedVideoTest() {
                          metadata.rawTags[2].tags["handler_name"]);
     chrome.test.assertEq("eng", metadata.rawTags[2].tags["language"]);
 
+    chrome.test.assertEq(0, metadata.attachedPictures.length);
+
     chrome.test.succeed();
   }
 
@@ -144,6 +177,7 @@ chrome.test.getConfig(function(config) {
     testsToRun = testsToRun.concat([
       MP3MIMETypeOnlyTest,
       MP3TagsTest,
+      MP3AttachedImageTest,
       RotatedVideoTest
     ]);
   }