Media Galleries API: Audio/Video attached pictures support.

chrome/common/extensions/api/media_galleries.idl

Index: chrome/common/extensions/api/media_galleries.idl
diff --git a/chrome/common/extensions/api/media_galleries.idl b/chrome/common/extensions/api/media_galleries.idl
index 0955f09b2f4e606860aca5d960e4e4901bc224d0..131ce60ce2dc201852a4bfa032a95d10a0309b42 100644
--- a/chrome/common/extensions/api/media_galleries.idl
+++ b/chrome/common/extensions/api/media_galleries.idl
@@ -17,8 +17,10 @@ namespace mediaGalleries {
   };
 
   [inline_doc] enum GetMetadataType {
-    // Retrieve all available metadata.
+    // Retrieve the mime type, metadata tags, and attached pictures.

[vandebo (ex-Chrome), 2014/04/23 23:22:45]

Is there any benefit (speed?) to retrieving the attached pictures [maybe images
is a better word here] and not the tags?

[tommycli, 2014/04/29 00:15:51]

Not sure, but I doubt it. At least in the FFMpeg code flow, to access the
attached pictures, you would have already read-in the media file's headers (with
its metadata).

     all,
+    // Retrieve only the mime type and the metadata tags.
+    mimeTypeAndTags,
     // Retrieve only the mime type.
     mimeTypeOnly
   };
@@ -147,6 +149,10 @@ namespace mediaGalleries {
     // All the metadata in the media file. For formats with multiple streams,
     // stream order will be preserved. Container metadata is the first element.
     StreamInfo[] rawTags;
+    
+    // The pictures embedded in the media file's metadata. This is most often

[vandebo (ex-Chrome), 2014/04/23 23:22:45]

s/pictures/images/

[tommycli, 2014/04/29 00:15:51]

Done. You mean just the comment, and not all the variable names right? (I used
'pictures' just because that's how ffmpeg refers to it. I have no objection to
using images everywhere if that makes more sense to you)

[vandebo (ex-Chrome), 2014/04/29 16:09:03]

images is shorter and more general than pictures, but I care much more about the
public interface.

[tommycli, 2014/04/29 22:57:00]

Done.

+    // used for album art or video thumbnails.
+    [instanceof=Blob] object[] attachedPictures;
   };
 
   callback MediaMetadataCallback = void (MediaMetadata metadata);