Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2501243002: Fix a minor bug in compressedTex{Sub}Image in blink. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a minor bug in compressedTex{Sub}Image in blink. The issue is in error case, we should return early instead of calling into lower level APIs. Otherwise out-of-bounds visits happen. BUG=664643 TEST=asan build with views-with-offsets.html R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1fa298aceb14ff8370addedf502c9fdf7a6f3a1f Cr-Commit-Position: refs/heads/master@{#432072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 4 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Ken Russell (switch to Gerrit)
Thank you for tracking this down!!! LGTM
4 years, 1 month ago (2016-11-15 01:00:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501243002/1
4 years, 1 month ago (2016-11-15 01:03:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 03:36:06 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 03:43:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fa298aceb14ff8370addedf502c9fdf7a6f3a1f
Cr-Commit-Position: refs/heads/master@{#432072}

Powered by Google App Engine
This is Rietveld 408576698