Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2500963005: Adding a category specific string for the empty foreign tabs suggestions section. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a category specific string for the empty foreign tabs suggestions section. Previously the foreign tabs section used the generic empty section text. This change adds a custom string to make it slightly me specific and useful. Another benefit of the string we choose, it is explains that this section shows tabs from other devices, which isn't currently explained by the section header. BUG=663966 Committed: https://crrev.com/e1d6d4ff4e5c4a8e010406f7f5e8866f7722cb5f Cr-Commit-Position: refs/heads/master@{#432484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
skym
PTAL
4 years, 1 month ago (2016-11-15 21:36:38 UTC) #7
Marc Treib
lgtm
4 years, 1 month ago (2016-11-16 09:32:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500963005/1
4 years, 1 month ago (2016-11-16 14:50:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 14:55:38 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 15:00:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1d6d4ff4e5c4a8e010406f7f5e8866f7722cb5f
Cr-Commit-Position: refs/heads/master@{#432484}

Powered by Google App Engine
This is Rietveld 408576698