Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Issue 2500963005: Adding a category specific string for the empty foreign tabs suggestions section. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
index 79c4b85c8cd8a3e150dee87efb60c004bc0c1194..d269f6807dbea0836a523ad3b16c057b585d8795 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
@@ -117,17 +117,15 @@ CategoryStatus ForeignSessionsSuggestionsProvider::GetCategoryStatus(
CategoryInfo ForeignSessionsSuggestionsProvider::GetCategoryInfo(
Category category) {
DCHECK_EQ(category, provided_category_);
- return CategoryInfo(
- l10n_util::GetStringUTF16(
- IDS_NTP_FOREIGN_SESSIONS_SUGGESTIONS_SECTION_HEADER),
- ContentSuggestionsCardLayout::MINIMAL_CARD,
- /*has_more_action=*/false,
- /*has_reload_action=*/false,
- /*has_view_all_action=*/true,
- /*show_if_empty=*/false,
- l10n_util::GetStringUTF16(IDS_NTP_SUGGESTIONS_SECTION_EMPTY));
- // TODO(skym): Replace IDS_NTP_SUGGESTIONS_SECTION_EMPTY with a
- // category-specific string.
+ return CategoryInfo(l10n_util::GetStringUTF16(
+ IDS_NTP_FOREIGN_SESSIONS_SUGGESTIONS_SECTION_HEADER),
+ ContentSuggestionsCardLayout::MINIMAL_CARD,
+ /*has_more_action=*/false,
+ /*has_reload_action=*/false,
+ /*has_view_all_action=*/true,
+ /*show_if_empty=*/false,
+ l10n_util::GetStringUTF16(
+ IDS_NTP_FOREIGN_SESSIONS_SUGGESTIONS_SECTION_EMPTY));
}
void ForeignSessionsSuggestionsProvider::DismissSuggestion(
« no previous file with comments | « no previous file | components/ntp_snippets_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698