Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2500863003: Revert of MIPS: Optimize load/store with large offset (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic, dusan.simicic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: Optimize load/store with large offset (patchset #1 id:1 of https://codereview.chromium.org/2486283003/ ) Reason for revert: Breaks CQ trybots now, i.e. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/24703/steps/compile%20with%20ninja/logs/stdio Original issue's description: > MIPS: Optimize load/store with large offset > > Currently, we are using the following sequence for load/store with large offset (offset > 16b): > > lui at, 0x1234 > ori at, at, 0x5678 > add at, s0, at > lw a0, 0(at) > > This sequence can be optimized in the following way: > > lui at, 0x1234 > add at, s0, at > lw a0, 0x5678(at) > > BUG= TBR=ivica.bogosavljevic@imgtec.com,miran.karic@imgtec.com,v8-mips-ports@googlegroups.com,dusan.simicic@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/fae0e710fc528e1d990aa409f6347b6ee00e3eae Cr-Commit-Position: refs/heads/master@{#40959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -99 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +2 lines, -24 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 14 chunks +32 lines, -63 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of MIPS: Optimize load/store with large offset
4 years, 1 month ago (2016-11-14 11:43:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500863003/1
4 years, 1 month ago (2016-11-14 11:43:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 11:43:42 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fae0e710fc528e1d990aa409f6347b6ee00e3eae
Cr-Commit-Position: refs/heads/master@{#40959}

Powered by Google App Engine
This is Rietveld 408576698