Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 2500863002: Ozone Linux: Fix build error in ui/ozone/demo/gl_renderer.cc (Closed)

Created:
4 years, 1 month ago by fwang
Modified:
4 years, 1 month ago
Reviewers:
rjkroege, tonikitoo
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, tonikitoo, Tom (Use chromium acct)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone Linux: Fix build error in ui/ozone/demo/gl_renderer.cc This CL fixes the regression introduced in [1] that makes the Ozone Linux build fail with the following error: ../../ui/ozone/demo/gl_renderer.cc:27:40: error: reference to type 'const gl::GLContextAttribs' could not bind to an rvalue of type 'gl::GpuPreference' [1] https://codereview.chromium.org/2480373002 BUG=angleproject:1518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/ozone/demo/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
fwang
PTAL
4 years, 1 month ago (2016-11-14 11:08:30 UTC) #2
tonikitoo
non-owner lgtm
4 years, 1 month ago (2016-11-14 13:35:32 UTC) #4
Geoff Lang
Should be fixed once this CL lands: https://codereview.chromium.org/2492223002/
4 years, 1 month ago (2016-11-14 15:13:52 UTC) #9
fwang
4 years, 1 month ago (2016-11-14 15:17:15 UTC) #10
On 2016/11/14 15:13:52, Geoff Lang wrote:
> Should be fixed once this CL lands:
https://codereview.chromium.org/2492223002/

Thanks. It looks we can close this one.

Powered by Google App Engine
This is Rietveld 408576698