Flush out initial [un]registerServiceWorker roundtrip

content/renderer/render_frame_impl.h

Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index dd652ef93d2f9ec6187e01d24974593185c4a7ad..fe85bdf9896f317f63aa764289c4a0fbf50d1012 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -53,6 +53,8 @@ class CONTENT_EXPORT RenderFrameImpl
       WebKit::WebFrame* frame,
       WebKit::WebApplicationCacheHostClient* client);
   virtual WebKit::WebCookieJar* cookieJar(WebKit::WebFrame* frame);
+  virtual WebKit::WebServiceWorkerRegistry* serviceWorkerRegistry(

[michaeln, 2013/10/04 01:26:07]

I think I'd like to back up to the original blink CL and re review just what it
is that we're doing and how. I think primary purpose of these initial CLs is to
setup how it hangs together, but afaict, it just isn't hanging just yet.

Let's change the webkitAPI in a few ways.

1) Let's make the returned object be that per-document thing and name it in some
way that's better than 'registry'.

2) Put 'create' at the front of the method name to make it clear that it
manufactures this object and passes ownership to blink.

3) Change the usages of this method in blink to have the same semantics in mind.
Blink needs to provide storage for the return value and call delete on it at
some point.

As currently coded in blink + this CL, serviceWorkerRegistry() is invoked for
each scriptable API call and the instance returned here is leaked.

[kinuko, 2013/10/04 14:55:48]

+1, except that I have not fully understood how WebSWRegistry is meant to be
used.  Does it really need to be implemented by chrome and kept in Blink?  If
what we need is a {un,}registration API and per-document registry for SWs it
sounds like we can separate them.

+      WebKit::WebFrame* frame);
   virtual void didAccessInitialDocument(WebKit::WebFrame* frame);
   virtual void didCreateFrame(WebKit::WebFrame* parent,
                               WebKit::WebFrame* child);