Flush out initial [un]registerServiceWorker roundtrip

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include "base/basictypes.h"
 #include "content/public/renderer/render_frame.h"
 #include "ipc/ipc_message.h"
@@ skipping 35 matching lines @@
       const WebKit::WebString& name,
       unsigned long long document_id);
   virtual WebKit::WebMediaPlayer* createMediaPlayer(
       WebKit::WebFrame* frame,
       const WebKit::WebURL& url,
       WebKit::WebMediaPlayerClient* client);
   virtual WebKit::WebApplicationCacheHost* createApplicationCacheHost(
       WebKit::WebFrame* frame,
       WebKit::WebApplicationCacheHostClient* client);
   virtual WebKit::WebCookieJar* cookieJar(WebKit::WebFrame* frame);
+  virtual WebKit::WebServiceWorkerRegistry* serviceWorkerRegistry(

[michaeln, 2013/10/04 01:26:07]

I think I'd like to back up to the original blink CL and re review just what it
is that we're doing and how. I think primary purpose of these initial CLs is to
setup how it hangs together, but afaict, it just isn't hanging just yet.

Let's change the webkitAPI in a few ways.

1) Let's make the returned object be that per-document thing and name it in some
way that's better than 'registry'.

2) Put 'create' at the front of the method name to make it clear that it
manufactures this object and passes ownership to blink.

3) Change the usages of this method in blink to have the same semantics in mind.
Blink needs to provide storage for the return value and call delete on it at
some point.

As currently coded in blink + this CL, serviceWorkerRegistry() is invoked for
each scriptable API call and the instance returned here is leaked.

[kinuko, 2013/10/04 14:55:48]

+1, except that I have not fully understood how WebSWRegistry is meant to be
used.  Does it really need to be implemented by chrome and kept in Blink?  If
what we need is a {un,}registration API and per-document registry for SWs it
sounds like we can separate them.

+      WebKit::WebFrame* frame);
   virtual void didAccessInitialDocument(WebKit::WebFrame* frame);
   virtual void didCreateFrame(WebKit::WebFrame* parent,
                               WebKit::WebFrame* child);
   virtual void didDisownOpener(WebKit::WebFrame* frame);
   virtual void frameDetached(WebKit::WebFrame* frame);
   virtual void willClose(WebKit::WebFrame* frame);
   virtual void didChangeName(WebKit::WebFrame* frame,
                              const WebKit::WebString& name);
   virtual void loadURLExternally(WebKit::WebFrame* frame,
                                  const WebKit::WebURLRequest& request,
@@ skipping 121 matching lines @@
   int routing_id_;
   bool is_swapped_out_;
   bool is_detaching_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_