Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Issue 2500793002: Internals.setValueForUser(): add argument type check. (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Internals.setValueForUser(): add argument type check. R=tkent BUG=642066 Committed: https://crrev.com/827f68d2c9eda095e2f5876b846868efe4535c58 Cr-Commit-Position: refs/heads/master@{#431845}

Patch Set 1 #

Patch Set 2 : constrain argument type via IDL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
sof
please take a look.
4 years, 1 month ago (2016-11-13 22:00:29 UTC) #5
tkent
Maybe changing the argument type of setValueForUser() is better. Element -> HTMLInputElement.
4 years, 1 month ago (2016-11-14 01:36:54 UTC) #8
sof
On 2016/11/14 01:36:54, tkent wrote: > Maybe changing the argument type of setValueForUser() is better. ...
4 years, 1 month ago (2016-11-14 07:39:20 UTC) #12
tkent
lgtm
4 years, 1 month ago (2016-11-14 07:40:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500793002/20001
4 years, 1 month ago (2016-11-14 09:00:32 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 09:04:57 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 09:07:53 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/827f68d2c9eda095e2f5876b846868efe4535c58
Cr-Commit-Position: refs/heads/master@{#431845}

Powered by Google App Engine
This is Rietveld 408576698