third_party/WebKit/Source/core/testing/Internals.cpp - Issue 2500793002: Internals.setValueForUser(): add argument type check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2500793002: Internals.setValueForUser(): add argument type check. (Closed)

Patch Set: constrain argument type via IDL Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/Internals.cpp

diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp

index 738cb42c4369aa551c5fe1d2f715f1f6c5974fd7..28863b32bc34f0f8a5f5e91f26cb4decf88bcba5 100644

--- a/third_party/WebKit/Source/core/testing/Internals.cpp

+++ b/third_party/WebKit/Source/core/testing/Internals.cpp

@@ -2764,8 +2764,9 @@ DEFINE_TRACE(Internals) {

ContextLifecycleObserver::trace(visitor);

}

-void Internals::setValueForUser(Element* element, const String& value) {

- toHTMLInputElement(element)->setValueForUser(value);

+void Internals::setValueForUser(HTMLInputElement* element,

+ const String& value) {

+ element->setValueForUser(value);

}

String Internals::textSurroundingNode(Node* node,