Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250063002: Browser Plugin: Simplified guest attachment (Closed)

Created:
6 years, 8 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Browser Plugin: Simplified guest attachment BUG=330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266640

Patch Set 1 #

Patch Set 2 : More cleanup #

Total comments: 1

Patch Set 3 : Fixed broken test and addresssed nit #

Patch Set 4 : Fix rebase #

Patch Set 5 : Fixed tests #

Patch Set 6 : Fixed New Window API test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -131 lines) Patch
M chrome/renderer/resources/extensions/web_view.js View 1 2 3 4 5 5 chunks +25 lines, -17 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 3 chunks +2 lines, -8 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 7 chunks +15 lines, -73 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_bindings.cc View 5 chunks +7 lines, -28 lines 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin_manager.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/browser_plugin_dragging.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/browser_plugin_embedder.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/browser_plugin_focus.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
Fady Samuel
6 years, 8 months ago (2014-04-23 19:40:42 UTC) #1
lazyboy
lgtm https://chromiumcodereview.appspot.com/250063002/diff/20001/chrome/renderer/resources/extensions/web_view.js File chrome/renderer/resources/extensions/web_view.js (right): https://chromiumcodereview.appspot.com/250063002/diff/20001/chrome/renderer/resources/extensions/web_view.js#newcode573 chrome/renderer/resources/extensions/web_view.js:573: self.attachWindow(detail.windowId); nit: probably self.attachWindowAndSetUpEvents() is better.
6 years, 8 months ago (2014-04-23 20:42:07 UTC) #2
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-23 21:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/250063002/40001
6 years, 8 months ago (2014-04-23 21:46:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 22:27:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-23 22:27:55 UTC) #6
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-23 22:37:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/250063002/60001
6 years, 8 months ago (2014-04-23 22:38:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 23:22:13 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=174588
6 years, 8 months ago (2014-04-23 23:22:14 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-23 23:43:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/250063002/80001
6 years, 8 months ago (2014-04-23 23:44:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 00:29:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 00:29:06 UTC) #14
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-24 19:56:38 UTC) #15
Fady Samuel
The CQ bit was unchecked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-24 20:53:26 UTC) #16
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-24 20:53:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/250063002/100001
6 years, 8 months ago (2014-04-24 21:08:32 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:39:48 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 22:39:49 UTC) #20
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-04-28 17:28:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/250063002/100001
6 years, 7 months ago (2014-04-28 17:29:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/250063002/100001
6 years, 7 months ago (2014-04-28 17:55:04 UTC) #23
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 20:00:38 UTC) #24
Message was sent while issue was closed. 
Change committed as 266640

Powered by Google App Engine
This is Rietveld 408576698