content/renderer/browser_plugin/mock_browser_plugin_manager.cc - Issue 250063002: Browser Plugin: Simplified guest attachment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/mock_browser_plugin_manager.cc

Issue 250063002: Browser Plugin: Simplified guest attachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed New Window API test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/browser_plugin/mock_browser_plugin_manager.cc

diff --git a/content/renderer/browser_plugin/mock_browser_plugin_manager.cc b/content/renderer/browser_plugin/mock_browser_plugin_manager.cc

index 197930eac95b004bbe1e4ca0282503b5b6db3a96..282edc0459083b8e60e4c5dc5008cf56542cb428 100644

--- a/content/renderer/browser_plugin/mock_browser_plugin_manager.cc

+++ b/content/renderer/browser_plugin/mock_browser_plugin_manager.cc

@@ -41,9 +41,8 @@ void MockBrowserPluginManager::AllocateInstanceID(

void MockBrowserPluginManager::AllocateInstanceIDACK(

BrowserPlugin* browser_plugin,

int guest_instance_id) {

- browser_plugin->OnInstanceIDAllocated(guest_instance_id);

scoped_ptr<base::DictionaryValue> extra_params(new base::DictionaryValue());

- browser_plugin->Attach(extra_params.Pass());

+ browser_plugin->Attach(guest_instance_id, extra_params.Pass());

}

bool MockBrowserPluginManager::Send(IPC::Message* msg) {