Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2500603002: Revert of TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only

Created:
4 years, 1 month ago by jaydasika
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only if we ar… (patchset #1 id:1 of https://codereview.chromium.org/2493943003/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=664408 Original issue's description: > TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only if we are changing the transforms stored on the root or the contents_root node. Otherwise, we will end up updating transforms every frame. > > BUG=663068 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Review-Url: https://codereview.chromium.org/2490773002 > Cr-Commit-Position: refs/heads/master@{#431000} > (cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7) > > Committed: https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882831d290fe9b7 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663068, 664408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M cc/trees/property_tree.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
jaydasika
4 years, 1 month ago (2016-11-11 19:34:09 UTC) #2
Created Revert of TransformTree::SetRootTransformsAndScales should set
'needs_update' on transform tree only if we ar…

Powered by Google App Engine
This is Rietveld 408576698