Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/wasm/wasm-module.h

Issue 2500443004: [wasm] OOB traps: build protected instruction list during codegen (Closed)
Patch Set: Merging with master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 2dded1e1c411bd05d0d6a4a37d4341cb2f0ced5f..70fc870562d3c5f10bd3c65d11826f6cbc464dac 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -11,6 +11,7 @@
#include "src/globals.h"
#include "src/handles.h"
#include "src/parsing/preparse-data.h"
+#include "src/trap-handler/trap-handler.h"
#include "src/wasm/managed.h"
#include "src/wasm/signature-map.h"
@@ -29,6 +30,9 @@ class CallDescriptor;
class WasmCompilationUnit;
}
+using trap_handler::ProtectedInstructionData;
titzer 2016/11/30 17:31:12 Is it necessary to add these here?
Eric Holk 2016/11/30 20:16:20 No. Done.
+using trap_handler::ProtectedInstructionList;
+
namespace wasm {
class ErrorThrower;
@@ -178,6 +182,8 @@ struct WasmExport {
enum ModuleOrigin { kWasmOrigin, kAsmJsOrigin };
+enum TrapFields { kTrapCodeOffset, kTrapLandingOffset, kTrapDataSize };
titzer 2016/11/30 17:31:12 Should this move to wasm-objects.h? I think it ref
titzer 2016/11/30 17:31:13 Maybe this fits better in wasm-objects.h? As I thi
Eric Holk 2016/11/30 20:16:20 I moved it to objects.h, because the protected ins
+
// Static representation of a module.
struct V8_EXPORT_PRIVATE WasmModule {
static const uint32_t kPageSize = 0x10000; // Page size, 64kb.
« src/trap-handler/trap-handler.h ('K') | « src/v8.gyp ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698