[wasm] OOB traps: build protected instruction list during codegen

src/wasm/wasm-module.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_WASM_MODULE_H_
 #define V8_WASM_MODULE_H_
 
 #include <memory>
 
 #include "src/api.h"
 #include "src/globals.h"
 #include "src/handles.h"
 #include "src/parsing/preparse-data.h"
+#include "src/trap-handler/trap-handler.h"
 
 #include "src/wasm/managed.h"
 #include "src/wasm/signature-map.h"
 #include "src/wasm/wasm-opcodes.h"
 
 namespace v8 {
 namespace internal {
 
 class WasmCompiledModule;
 class WasmDebugInfo;
 class WasmModuleObject;
 class WasmInstanceObject;
 
 namespace compiler {
 class CallDescriptor;
 class WasmCompilationUnit;
 }
 
+using trap_handler::ProtectedInstructionData;

[titzer, 2016/11/30 17:31:12]

Is it necessary to add these here?

[Eric Holk, 2016/11/30 20:16:20]

No. Done.

+using trap_handler::ProtectedInstructionList;
+
 namespace wasm {
 class ErrorThrower;
 
 const size_t kMaxModuleSize = 1024 * 1024 * 1024;
 const size_t kMaxFunctionSize = 128 * 1024;
 const size_t kMaxStringSize = 256;
 const uint32_t kWasmMagic = 0x6d736100;
 const uint32_t kWasmVersion = 0x0d;
 
 const uint8_t kWasmFunctionTypeForm = 0x60;
@@ skipping 129 matching lines @@
 // Static representation of a WASM export.
 struct WasmExport {
   uint32_t name_length;   // length in bytes of the exported name.
   uint32_t name_offset;   // offset in module bytes of the name to export.
   WasmExternalKind kind;  // kind of the export.
   uint32_t index;         // index into the respective space.
 };
 
 enum ModuleOrigin { kWasmOrigin, kAsmJsOrigin };
 
+enum TrapFields { kTrapCodeOffset, kTrapLandingOffset, kTrapDataSize };

[titzer, 2016/11/30 17:31:12]

Should this move to wasm-objects.h? I think it refers to entries within the
FixedArray there.

[titzer, 2016/11/30 17:31:13]

Maybe this fits better in wasm-objects.h? As I think this refers to the entries
in the FixedArray, yes?

[Eric Holk, 2016/11/30 20:16:20]

I moved it to objects.h, because the protected instruction array actually moved
into the Code object as well.

Done.

+
 // Static representation of a module.
 struct V8_EXPORT_PRIVATE WasmModule {
   static const uint32_t kPageSize = 0x10000;    // Page size, 64kb.
   static const uint32_t kMinMemPages = 1;       // Minimum memory size = 64kb
   static const size_t kV8MaxPages = 16384;      // Maximum memory size = 1gb
   static const size_t kSpecMaxPages = 65536;    // Maximum according to the spec
   static const size_t kV8MaxTableSize = 16 * 1024 * 1024;
 
   Zone* owned_zone;
   const byte* module_start = nullptr;  // starting address for the module bytes
@@ skipping 254 matching lines @@
 void ValidateModuleState(Isolate* isolate, Handle<WasmModuleObject> module_obj);
 void ValidateOrphanedInstance(Isolate* isolate,
                               Handle<WasmInstanceObject> instance);
 
 }  // namespace testing
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_WASM_MODULE_H_