Changes behavior of iOS-specific gfx::Image constructor.

Changes behavior of iOS-specific gfx::Image constructor.

Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*) constructor from consuming +1 refcount to retaining the argument.

TEST=none
BUG=645125
Committed: https://crrev.com/2a1f622ddc372a0bd4206fb01c45f4ebbe37258b
Cr-Commit-Position: refs/heads/master@{#438223}

[stkhapugin, 2016-11-22 14:07:36]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org, thakis@chromium.org

[stkhapugin, 2016-11-22 14:07:37]

PTAL

[Nico, 2016-12-02 01:12:44]

(i'm waiting for sdefresne to look at this series; happy to stamp once he's
happy.)

[stkhapugin, 2016-12-06 12:19:52]

Description was changed from

==========
Changes behavior of iOS-specific gfx::Image constructor.

Changes the constructor to retain its argument.

This is a part of several CLs:
1. CL 2504683002. Adds a new constructor.
2. A downstream CL that changes all usage of old constructor to the new
one.
3. An upstream CL changing the default behavior of the old constructor
to not assume the argument to be retained. [This CL]
4. A downstream CL that migrates all usage of new constructor back to
the old one.
5. An upstream CL that removes the new constructor.

TEST=none
BUG=645125
==========

to

==========
Changes behavior of iOS-specific gfx::Image constructor.


Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor
to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*)
constructor from consuming +1 refcount to retaining the argument.  


TEST=none
BUG=645125
==========

[stkhapugin, 2016-12-06 12:25:20]

Sylvain, PTAL

[sdefresne, 2016-12-06 12:28:01]

I think you added files that should not be part of this CL (anything below
help/). Please remove them.

[stkhapugin, 2016-12-06 12:55:57]

PTAL, sorry for that.

[sdefresne, 2016-12-06 13:04:15]

lgtm

[Nico, 2016-12-06 13:52:34]

lgtm; i'm assuming you've checked that all callers won't leak after this

[stkhapugin, 2016-12-13 17:00:47]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:01:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 18:07:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481648447808150,
"parent_rev": "cf690f3a3adbf8b9f5acbd11a6e9487ab38cf229", "commit_rev":
"969a131595a580a6f263e023bbd0a752acf59d5c"}

[commit-bot: I haz the power, 2016-12-13 18:07:44]

Description was changed from

==========
Changes behavior of iOS-specific gfx::Image constructor.


Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor
to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*)
constructor from consuming +1 refcount to retaining the argument.  


TEST=none
BUG=645125
==========

to

==========
Changes behavior of iOS-specific gfx::Image constructor.


Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor
to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*)
constructor from consuming +1 refcount to retaining the argument.  


TEST=none
BUG=645125

Review-Url: https://codereview.chromium.org/2500373004
==========

[commit-bot: I haz the power, 2016-12-13 18:07:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 18:11:49]

Description was changed from

==========
Changes behavior of iOS-specific gfx::Image constructor.


Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor
to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*)
constructor from consuming +1 refcount to retaining the argument.  


TEST=none
BUG=645125

Review-Url: https://codereview.chromium.org/2500373004
==========

to

==========
Changes behavior of iOS-specific gfx::Image constructor.

Chrome iOS is moving to Objective-C Automatic Reference Counting. Under
it, arguments are supposed to be autoreleased. This CL changes the constructor
to retain its argument..
This is a part of a multiple CL setup that will change the Image(UIImage*)
constructor from consuming +1 refcount to retaining the argument.

TEST=none
BUG=645125

Committed: https://crrev.com/2a1f622ddc372a0bd4206fb01c45f4ebbe37258b
Cr-Commit-Position: refs/heads/master@{#438223}
==========

[commit-bot: I haz the power, 2016-12-13 18:11:51]

Patchset 3 (id:??) landed as
https://crrev.com/2a1f622ddc372a0bd4206fb01c45f4ebbe37258b
Cr-Commit-Position: refs/heads/master@{#438223}